New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Fix linter after Go 1.18 upgrade #4945
Conversation
Signed-off-by: nolouch <nolouch@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4945 +/- ##
==========================================
- Coverage 75.31% 75.31% -0.01%
==========================================
Files 297 297
Lines 29471 29472 +1
==========================================
Hits 22197 22197
- Misses 5335 5337 +2
+ Partials 1939 1938 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: nolouch <nolouch@gmail.com>
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 34265c0
|
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
ref #4944
Issue Number: Close #4944
What is changed and how does it work?
Check List
Tests
Release note