Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fix linter after Go 1.18 upgrade #4945

Merged
merged 3 commits into from May 13, 2022
Merged

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented May 13, 2022

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

ref #4944
Issue Number: Close #4944

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #4945 (34265c0) into master (cbd7145) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #4945      +/-   ##
==========================================
- Coverage   75.31%   75.31%   -0.01%     
==========================================
  Files         297      297              
  Lines       29471    29472       +1     
==========================================
  Hits        22197    22197              
- Misses       5335     5337       +2     
+ Partials     1939     1938       -1     
Flag Coverage Δ
unittests 75.31% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/autoscaling/prometheus.go 72.22% <0.00%> (ø)
tools/pd-ctl/pdctl/command/store_command.go 63.79% <100.00%> (+0.08%) ⬆️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/storage/storage.go 64.86% <0.00%> (-5.41%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/election/leadership.go 73.19% <0.00%> (-4.13%) ⬇️
pkg/etcdutil/etcdutil.go 86.20% <0.00%> (-2.30%) ⬇️
pkg/dashboard/adapter/manager.go 77.01% <0.00%> (-2.30%) ⬇️
server/tso/tso.go 69.49% <0.00%> (-2.26%) ⬇️
server/storage/endpoint/meta.go 59.55% <0.00%> (-2.25%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd7145...34265c0. Read the comment docs.

Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
@nolouch
Copy link
Contributor Author

nolouch commented May 13, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 34265c0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@ti-chi-bot ti-chi-bot merged commit dd8d0b0 into tikv:master May 13, 2022
@nolouch nolouch deleted the fix-lint-go1.18 branch May 13, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter panic after upgrade to Go1.18
4 participants