scheduler: refactor calcProgressiveRank in hot-scheduler #4950
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4950 +/- ##
==========================================
- Coverage 75.33% 75.31% -0.03%
==========================================
Files 297 297
Lines 29497 29462 -35
==========================================
- Hits 22223 22189 -34
Misses 5332 5332
+ Partials 1942 1941 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: lhy1024 <admin@liudos.us>
| // If belong to the case, two dim will be more balanced, the best choice. | ||
| if !bs.isTolerance(src, dst, bs.firstPriority) || !bs.isTolerance(src, dst, bs.secondPriority) { | ||
| return | ||
| } | ||
| bs.cur.progressiveRank = -3 |
There was a problem hiding this comment.
how about use enum to replace progressiveRank like -3, -2 , -1?
There was a problem hiding this comment.
we will add more case in another pr
ti-chi-bot
added
status/LGT2
|
/merge |
|
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: e1cb31a
|
ti-chi-bot
added
the
status/can-merge
Signed-off-by: lhy1024 admin@liudos.us
What problem does this PR solve?
Issue Number: Ref #4949
What is changed and how does it work?
Check List
Tests
Release note