Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: implement for BucketStatInformer #4992

Merged
merged 4 commits into from May 19, 2022

Conversation

bufferflies
Copy link
Contributor

What problem does this PR solve?

Issue Number: Close #4991

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

Release note

 None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from rleungx and Yisaer May 19, 2022 08:34
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2022
@ti-chi-bot
Copy link
Member

@bufferflies: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@bufferflies: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2022
@bufferflies bufferflies force-pushed the feature/bucket-hot-report branch 2 times, most recently from 033aa73 to 58cc16e Compare May 19, 2022 09:05
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

server/statistics/buckets/metric.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #4992 (431d7be) into master (61842c3) will decrease coverage by 0.12%.
The diff coverage is 79.48%.

@@            Coverage Diff             @@
##           master    #4992      +/-   ##
==========================================
- Coverage   75.54%   75.42%   -0.13%     
==========================================
  Files         306      307       +1     
  Lines       30194    30230      +36     
==========================================
- Hits        22811    22800      -11     
- Misses       5394     5431      +37     
- Partials     1989     1999      +10     
Flag Coverage Δ
unittests 75.42% <79.48%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mock/mockcluster/mockcluster.go 94.07% <33.33%> (-0.68%) ⬇️
server/cluster/cluster.go 82.78% <50.00%> (+0.32%) ⬆️
server/statistics/buckets/hot_bucket_task.go 85.71% <85.71%> (+35.71%) ⬆️
server/grpc_service.go 52.78% <100.00%> (-0.14%) ⬇️
server/metrics.go 100.00% <100.00%> (ø)
server/statistics/buckets/bucket_stat_informer.go 94.20% <100.00%> (+3.02%) ⬆️
server/statistics/buckets/hot_bucket_cache.go 90.09% <100.00%> (+7.68%) ⬆️
server/statistics/buckets/metric.go 100.00% <100.00%> (ø)
pkg/tempurl/tempurl.go 45.00% <0.00%> (-25.00%) ⬇️
server/storage/leveldb_backend.go 76.00% <0.00%> (-8.00%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61842c3...431d7be. Read the comment docs.

@nolouch nolouch requested review from JmPotato and removed request for Yisaer and rleungx May 19, 2022 09:18
server/metrics.go Outdated Show resolved Hide resolved
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2022
@nolouch nolouch requested a review from HunDunDM May 19, 2022 12:05
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2022
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 431d7be

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2022
@ti-chi-bot ti-chi-bot merged commit 9f1894a into tikv:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge split bucket scheduler and bucket statistics.
4 participants