unsafe recovery: Tombstone tiflash learners which have the latest log #5045

Connor1996 · 2022-05-26T10:40:39Z

Signed-off-by: Connor1996 zbk602423539@gmail.com

What problem does this PR solve?

Issue Number: Close #5044

What is changed and how does it work?

tombstone tiflash learners which have the latest log

Check List

Tests

Unit test
Manual test (add detailed scripts or steps below)

Related changes

Need to cherry-pick to the release branch

Release note

None

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

ti-chi-bot · 2022-05-26T10:40:41Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-05-26T10:49:04Z

Codecov Report

Merging #5045 (bfa3e58) into master (b86418d) will decrease coverage by 0.06%.
The diff coverage is 67.08%.

@@            Coverage Diff             @@
##           master    #5045      +/-   ##
==========================================
- Coverage   75.50%   75.43%   -0.07%     
==========================================
  Files         308      308              
  Lines       30291    30341      +50     
==========================================
+ Hits        22870    22888      +18     
- Misses       5433     5459      +26     
- Partials     1988     1994       +6

Flag	Coverage Δ
unittests	`75.43% <67.08%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/cluster/unsafe_recovery_controller.go	`80.03% <67.08%> (-1.41%)`	⬇️
pkg/tempurl/tempurl.go	`45.00% <0.00%> (-15.00%)`	⬇️
...erver/config/service_middleware_persist_options.go	`88.88% <0.00%> (-11.12%)`	⬇️
pkg/dashboard/adapter/manager.go	`79.31% <0.00%> (-6.90%)`	⬇️
server/tso/tso.go	`66.66% <0.00%> (-6.22%)`	⬇️
server/region_syncer/server.go	`82.06% <0.00%> (-5.44%)`	⬇️
server/tso/allocator_manager.go	`61.39% <0.00%> (-2.17%)`	⬇️
server/schedule/checker/rule_checker.go	`78.17% <0.00%> (-1.02%)`	⬇️
server/cluster/coordinator.go	`71.19% <0.00%> (-0.42%)`	⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86418d...bfa3e58. Read the comment docs.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

server/cluster/unsafe_recovery_controller.go

rleungx · 2022-05-27T02:30:16Z

server/cluster/unsafe_recovery_controller.go

+				return false
+			}
+			storeID := leader.storeID
+			if u.cluster.GetStore(storeID).IsTiFlash() {


Only a peer is in TiFlash and selected as a leader will be tombstone?

yes, as we can't make Tiflash to be the leader

more essentially, Tiflash can't generate snapshot

server/cluster/unsafe_recovery_controller.go

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

ti-chi-bot · 2022-05-27T07:20:05Z

@v01dstar: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

nolouch · 2022-05-27T09:46:33Z

/merge

ti-chi-bot · 2022-05-27T09:46:34Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-05-27T09:46:35Z

This pull request has been accepted and is ready to merge.

Commit hash: 8481f13

Connor1996 · 2022-05-27T09:51:58Z

/merge

ti-chi-bot · 2022-05-27T09:51:59Z

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Connor1996 · 2022-05-27T10:34:48Z

/test

ti-chi-bot · 2022-05-27T11:20:59Z

@Connor1996: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-05-27T11:33:24Z

In response to a cherrypick label: new pull request created: #5063.

…#5045) (#5063) close #5044, ref #5045 tombstone tiflash learners which have the latest log Signed-off-by: Connor1996 <zbk602423539@gmail.com> Co-authored-by: Connor1996 <zbk602423539@gmail.com> Co-authored-by: Connor <zbk602423539@gmail.com>

close tikv#5044 tombstone tiflash learners which have the latest log

4d4d409

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

ti-chi-bot added release-note-none needs-cherry-pick-release-6.1 labels May 26, 2022

ti-chi-bot requested review from rleungx and Yisaer May 26, 2022 10:40

Connor1996 added 2 commits May 26, 2022 18:50

update comment

915a2ab

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

update redact log

a5777aa

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

rleungx reviewed May 27, 2022

View reviewed changes

server/cluster/unsafe_recovery_controller.go Show resolved Hide resolved

rleungx reviewed May 27, 2022

View reviewed changes

server/cluster/unsafe_recovery_controller.go Outdated Show resolved Hide resolved

Connor1996 added 2 commits May 27, 2022 15:14

update log

19682f2

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Merge remote-tracking branch 'upstream/master' into unsafe-recover

87ba953

v01dstar approved these changes May 27, 2022

View reviewed changes

Connor1996 force-pushed the unsafe-recover branch 2 times, most recently from e61e49f to 83fdd6d Compare May 27, 2022 08:39

update graph

4352671

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Connor1996 force-pushed the unsafe-recover branch from 83fdd6d to 4352671 Compare May 27, 2022 08:41

rleungx approved these changes May 27, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022

avoid use tiflash to create new region

8481f13

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

nolouch approved these changes May 27, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022

Merge branch 'master' into unsafe-recover

bfa3e58

ti-chi-bot merged commit 80128d3 into tikv:master May 27, 2022

ti-chi-bot mentioned this pull request May 27, 2022

unsafe recovery: Tombstone tiflash learners which have the latest log (#5045) #5063

Merged

Connor1996 mentioned this pull request May 30, 2022

Support online recovery for Raft majority failure tikv/tikv#10483

Closed

44 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unsafe recovery: Tombstone tiflash learners which have the latest log #5045

unsafe recovery: Tombstone tiflash learners which have the latest log #5045

Connor1996 commented May 26, 2022

ti-chi-bot commented May 26, 2022 •

edited

codecov bot commented May 26, 2022 •

edited

rleungx May 27, 2022

Connor1996 May 27, 2022

Connor1996 May 27, 2022

ti-chi-bot commented May 27, 2022

nolouch commented May 27, 2022

ti-chi-bot commented May 27, 2022

ti-chi-bot commented May 27, 2022

Connor1996 commented May 27, 2022

ti-chi-bot commented May 27, 2022

Connor1996 commented May 27, 2022

ti-chi-bot commented May 27, 2022

ti-chi-bot commented May 27, 2022

unsafe recovery: Tombstone tiflash learners which have the latest log #5045

unsafe recovery: Tombstone tiflash learners which have the latest log #5045

Conversation

Connor1996 commented May 26, 2022

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented May 26, 2022 • edited

codecov bot commented May 26, 2022 • edited

Codecov Report

rleungx May 27, 2022

Choose a reason for hiding this comment

Connor1996 May 27, 2022

Choose a reason for hiding this comment

Connor1996 May 27, 2022

Choose a reason for hiding this comment

ti-chi-bot commented May 27, 2022

nolouch commented May 27, 2022

ti-chi-bot commented May 27, 2022

ti-chi-bot commented May 27, 2022

Connor1996 commented May 27, 2022

ti-chi-bot commented May 27, 2022

Connor1996 commented May 27, 2022

ti-chi-bot commented May 27, 2022

ti-chi-bot commented May 27, 2022

ti-chi-bot commented May 26, 2022 •

edited

codecov bot commented May 26, 2022 •

edited