Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: migrate test framework to testify #5101

Merged
merged 4 commits into from Jun 6, 2022

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Jun 2, 2022

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Issue Number: Close #5097

Check List

Tests

  • Unit test

Release note

None

close tikv#5097

Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/testing CI testing. label Jun 2, 2022
@disksing disksing requested a review from JmPotato June 2, 2022 10:41
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #5101 (5082985) into master (8359788) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head 5082985 differs from pull request most recent head 1a84749. Consider uploading reports for the commit 1a84749 to get more accurate results

@@            Coverage Diff             @@
##           master    #5101      +/-   ##
==========================================
+ Coverage   75.36%   75.52%   +0.15%     
==========================================
  Files         308      308              
  Lines       30475    30475              
==========================================
+ Hits        22969    23015      +46     
+ Misses       5498     5466      -32     
+ Partials     2008     1994      -14     
Flag Coverage Δ
unittests 75.52% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cache/lru.go 79.06% <0.00%> (-9.31%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/schedule/checker/rule_checker.go 78.17% <0.00%> (-1.02%) ⬇️
client/base_client.go 79.38% <0.00%> (-0.52%) ⬇️
client/client.go 68.72% <0.00%> (-0.32%) ⬇️
server/cluster/unsafe_recovery_controller.go 80.54% <0.00%> (ø)
server/cluster/cluster.go 83.50% <0.00%> (+0.09%) ⬆️
server/schedulers/hot_region.go 83.33% <0.00%> (+0.29%) ⬆️
server/cluster/coordinator.go 70.98% <0.00%> (+0.39%) ⬆️
server/grpc_service.go 53.05% <0.00%> (+0.44%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8359788...1a84749. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 6, 2022
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM


func (s *testManagerSuite) TestDeleteByIDPrefix(c *C) {
s.manager.SetRules([]*Rule{
func TestDeleteByIDPrefix(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line between the functions for this PR.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 6, 2022
Signed-off-by: disksing <i@disksing.com>
@disksing
Copy link
Contributor Author

disksing commented Jun 6, 2022

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ecb14b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2022
@ti-chi-bot
Copy link
Member

@disksing: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2022
@disksing
Copy link
Contributor Author

disksing commented Jun 6, 2022

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1a84749

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2022
@ti-chi-bot ti-chi-bot merged commit d02a98a into tikv:master Jun 6, 2022
@disksing disksing deleted the placement-testify branch June 6, 2022 14:45
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
close tikv#5097

Signed-off-by: disksing <i@disksing.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/testing CI testing. release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for server/schedule/placement
5 participants