Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/grpc_service: make the lock for UpdateServiceGCSafePoint smaller #5128

Merged
merged 5 commits into from Jun 15, 2022
Merged

server/grpc_service: make the lock for UpdateServiceGCSafePoint smaller #5128

merged 5 commits into from Jun 15, 2022

Conversation

AndreMouche
Copy link
Member

Signed-off-by: shirly AndreMouche@126.com

What problem does this PR solve?

Issue Number: Close #5019

Check List

Tests

  • Unit test

Release note

None.

@AndreMouche
server/grpc_service: move lock for UpdateServiceGCSafePoint into sub …
c6c66b9 
…function

Signed-off-by: shirly <AndreMouche@126.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jun 8, 2022 •
edited

Codecov Report

Merging #5128 (a6dd783) into master (d263b85) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5128      +/-   ##
==========================================
+ Coverage   75.59%   75.71%   +0.11%     
==========================================
  Files         309      309              
  Lines       30585    30586       +1     
==========================================
+ Hits        23121    23158      +37     
+ Misses       5463     5433      -30     
+ Partials     2001     1995       -6
Flag Coverage Δ
unittests 75.71% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/gc/safepoint.go 92.59% <100.00%> (+7.97%) ⬆️
server/grpc_service.go 52.24% <100.00%> (+0.15%) ⬆️
server/server.go 73.57% <100.00%> (+0.81%) ⬆️
pkg/dashboard/adapter/manager.go 79.31% <0.00%> (-6.90%) ⬇️
server/storage/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
client/base_client.go 79.38% <0.00%> (-3.10%) ⬇️
server/election/leadership.go 77.31% <0.00%> (-3.10%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/schedulers/evict_leader.go 78.82% <0.00%> (-0.91%) ⬇️
server/cluster/coordinator.go 70.84% <0.00%> (-0.79%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d263b85...a6dd783. Read the comment docs.

@rleungx
Copy link
Member

rleungx commented Jun 13, 2022

CI failed.

@AndreMouche
merge & fix conflicts
1c7bd5f 
Signed-off-by: shirly <AndreMouche@126.com>
@AndreMouche
fix tests
758bc78 
Signed-off-by: shirly <AndreMouche@126.com>
bufferflies
bufferflies reviewed Jun 15, 2022
View reviewed changes
server/gc/safepoint.go Outdated
return nil, false, err
}

// If the min safepoint is updated, load the next one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// If the min safepoint is updated, load the next one
// If the min safe point is updated, load the next one

bufferflies
bufferflies approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2022
rleungx
rleungx approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

server/gc/safepoint_test.go Outdated Show resolved Hide resolved
server/gc/safepoint_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2022
@AndreMouche
address comments
c9fb6cf 
Signed-off-by: shirly <AndreMouche@126.com>
@rleungx
Copy link
Member

rleungx commented Jun 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c9fb6cf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2022
@ti-chi-bot ti-chi-bot merged commit 5d744d3 into tikv:master Jun 15, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
@AndreMouche @ti-chi-bot @CabinfeverB
server/grpc_service: make the lock for UpdateServiceGCSafePoint sma…
fb0e669 
…ller (tikv#5128)

close tikv#5019

Signed-off-by: shirly <AndreMouche@126.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferflies bufferflies bufferflies approved these changes

@rleungx rleungx rleungx approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server/grpc_service: could we make the lock for the func UpdateServiceGCSafepoint smaller?
4 participants
@AndreMouche @ti-chi-bot @rleungx @bufferflies