filter: migrate test framework to testify

[LLThomas]

Signed-off-by: LLThomas zs033@qq.com

What problem does this PR solve?

Issue Number: Ref #4813

What is changed and how does it work?

Just as the title says.

Check List

Tests

• Unit test

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• CabinfeverB
• JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #5133 (5d33e61) into master (6c0985d) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5133      +/-   ##
==========================================
- Coverage   75.63%   75.47%   -0.16%     
==========================================
  Files         309      309              
  Lines       30518    30518              
==========================================
- Hits        23082    23034      -48     
- Misses       5436     5476      +40     
- Partials     2000     2008       +8     

Flag	Coverage Δ
unittests	75.47% <ø> (-0.16%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/tso/local_allocator.go	62.16% <0.00%> (-16.22%)	⬇️
server/tso/allocator_manager.go	63.22% <0.00%> (-5.50%)	⬇️
server/id/id.go	76.19% <0.00%> (-4.77%)	⬇️
server/tso/tso.go	69.49% <0.00%> (-3.39%)	⬇️
server/schedule/operator_controller.go	84.56% <0.00%> (-1.21%)	⬇️
tools/pd-ctl/pdctl/command/operator.go	66.66% <0.00%> (-1.15%)	⬇️
server/storage/hot_region_storage.go	78.14% <0.00%> (-1.10%)	⬇️
server/server.go	72.43% <0.00%> (-0.84%)	⬇️
server/grpc_service.go	52.08% <0.00%> (-0.71%)	⬇️
server/handler.go	52.58% <0.00%> (-0.39%)	⬇️
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0985d...5d33e61. Read the comment docs.

[LLThomas]

CI/CD log is here:

✘  https://revive.run/r#confusing-naming  Method 'NewCandidates' differs only by capitalization to function 'newCandidates' in /home/runner/work/pd/pd/server/schedule/filter/candidates_test.go  
  /home/runner/work/pd/pd/server/schedule/filter/candidates.go:32:6

The error is 'NewCandidates' in candidates.go differs only by capitalization to function 'newCandidates' in candidates_test.go. Should we give 'newCandidates' a new function name?

[JmPotato]

CI/CD log is here:

✘  https://revive.run/r#confusing-naming[](https://revive.run/r#confusing-naming)  Method 'NewCandidates' differs only by capitalization to function 'newCandidates' in /home/runner/work/pd/pd/server/schedule/filter/candidates_test.go  
  /home/runner/work/pd/pd/server/schedule/filter/candidates.go:32:6

The error is 'NewCandidates' in candidates.go differs only by capitalization to function 'newCandidates' in candidates_test.go. Should we give 'newCandidates' a new function name?

Yeah, we cound rename newCandidates to newTestCandidates.

[JmPotato]

LGTM. Please fix the check.

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 5d33e61