New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replica_strategy:speed up and reduce the complexity of selectStore to O(n) #5144
replica_strategy:speed up and reduce the complexity of selectStore to O(n) #5144
Conversation
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: shirly <AndreMouche@126.com>
Codecov Report
@@ Coverage Diff @@
## master #5144 +/- ##
==========================================
- Coverage 75.69% 75.55% -0.15%
==========================================
Files 309 309
Lines 30586 30598 +12
==========================================
- Hits 23153 23119 -34
- Misses 5437 5471 +34
- Partials 1996 2008 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: shirly <AndreMouche@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we wanted to implement a retry mechanism in ReplicaStrategy, this method may be not useful
Signed-off-by: shirly <AndreMouche@126.com>
Signed-off-by: shirly <AndreMouche@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Signed-off-by: shirly <AndreMouche@126.com>
0f30219
to
d94e80a
Compare
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d94e80a
|
What problem does this PR solve?
Issue Number: Close #5143
Check List
Tests
Release note