Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the PD role to Unknown when pd_tso_role value is null #5233

Merged

Conversation

matchge-ca
Copy link
Contributor

Signed-off-by: Hua Lu hua.lu@pingcap.com

What problem does this PR solve?

Issue Number: Close #5047

What is changed and how does it work?

Change the valueMaps definition for PD role panel to Unknown when pd_tso_role value is null,

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • Apply the changes to grafana
    • Check the role value is Unknown when the pd_tso_role is null or during the metric loading time

Code changes

Side effects

Related changes

Release note

None

Signed-off-by: Hua Lu <hua.lu@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 27, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@matchge-ca: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #5233 (c776e28) into master (844f5ed) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5233      +/-   ##
==========================================
+ Coverage   75.63%   75.70%   +0.06%     
==========================================
  Files         310      310              
  Lines       30708    30708              
==========================================
+ Hits        23226    23246      +20     
+ Misses       5485     5473      -12     
+ Partials     1997     1989       -8     
Flag Coverage Δ
unittests 75.70% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
server/storage/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
server/tso/tso.go 69.49% <0.00%> (-2.26%) ⬇️
server/schedule/operator_controller.go 85.77% <0.00%> (-0.81%) ⬇️
server/cluster/unsafe_recovery_controller.go 80.18% <0.00%> (-0.37%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (ø)
server/cluster/cluster.go 83.91% <0.00%> (+0.09%) ⬆️
server/grpc_service.go 51.79% <0.00%> (+0.35%) ⬆️
server/handler.go 52.96% <0.00%> (+0.38%) ⬆️
server/server.go 74.27% <0.00%> (+0.39%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844f5ed...c776e28. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 27, 2022
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d6ed164

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 27, 2022
@ti-chi-bot ti-chi-bot merged commit f031dc4 into tikv:master Jun 28, 2022
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
close tikv#5047

Signed-off-by: Hua Lu <hua.lu@pingcap.com>

Co-authored-by: 混沌DM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PD role panel on Grafana might cause mis-leading information
4 participants