New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the PD role to Unknown when pd_tso_role value is null #5233
Set the PD role to Unknown when pd_tso_role value is null #5233
Conversation
Signed-off-by: Hua Lu <hua.lu@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@matchge-ca: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #5233 +/- ##
==========================================
+ Coverage 75.63% 75.70% +0.06%
==========================================
Files 310 310
Lines 30708 30708
==========================================
+ Hits 23226 23246 +20
+ Misses 5485 5473 -12
+ Partials 1997 1989 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d6ed164
|
close tikv#5047 Signed-off-by: Hua Lu <hua.lu@pingcap.com> Co-authored-by: 混沌DM <hundundm@gmail.com>
Signed-off-by: Hua Lu hua.lu@pingcap.com
What problem does this PR solve?
Issue Number: Close #5047
What is changed and how does it work?
Change the
valueMaps
definition forPD role
panel to Unknown whenpd_tso_role
value is null,Check List
Tests
pd_tso_role
is null or during the metric loading timeCode changes
Side effects
Related changes
Release note
None