Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* : clean some repeat code about units #5314

Merged
merged 5 commits into from Jul 15, 2022
Merged

* : clean some repeat code about units #5314

merged 5 commits into from Jul 15, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 15, 2022

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Issue Number: Ref #5307

  1. replace KB,MB,GB with units pkg
  2. replace some 1024 with units pkg

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed labels Jul 15, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #5314 (009a0f1) into master (05444e2) will increase coverage by 0.04%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master    #5314      +/-   ##
==========================================
+ Coverage   75.72%   75.77%   +0.04%     
==========================================
  Files         312      312              
  Lines       30962    30962              
==========================================
+ Hits        23447    23462      +15     
+ Misses       5511     5500      -11     
+ Partials     2004     2000       -4     
Flag Coverage Δ
unittests 75.77% <90.90%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 78.22% <ø> (ø)
server/region_syncer/server.go 87.36% <ø> (+1.09%) ⬆️
server/statistics/buckets/bucket_stat_informer.go 94.20% <ø> (ø)
server/statistics/hot_peer_cache.go 96.89% <ø> (ø)
server/core/test_util.go 83.20% <60.00%> (ø)
pkg/mock/mockcluster/mockcluster.go 94.07% <100.00%> (ø)
server/core/region.go 91.27% <100.00%> (ø)
server/core/store.go 82.43% <100.00%> (ø)
server/schedule/range_cluster.go 83.33% <100.00%> (ø)
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04b89e...009a0f1. Read the comment docs.

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 marked this pull request as ready for review July 15, 2022 07:44
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

server/schedulers/hot_region_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2022
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 009a0f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022
@ti-chi-bot ti-chi-bot merged commit 51ad29c into tikv:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants