Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: show stores of peers in pd-ctl output #5330

Merged
merged 6 commits into from
Jul 28, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jul 19, 2022

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Issue Number: Ref #4949

What is changed and how does it work?

image

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 requested a review from HunDunDM July 19, 2022 06:28
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #5330 (8b2c6c6) into master (3df67ab) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5330      +/-   ##
==========================================
- Coverage   75.64%   75.60%   -0.04%     
==========================================
  Files         312      312              
  Lines       31041    31045       +4     
==========================================
- Hits        23482    23473       -9     
- Misses       5549     5572      +23     
+ Partials     2010     2000      -10     
Flag Coverage Δ
unittests 75.60% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/handler.go 52.03% <100.00%> (-0.94%) ⬇️
server/statistics/hot_peer.go 96.87% <100.00%> (+0.26%) ⬆️
server/statistics/hot_peer_cache.go 96.92% <100.00%> (+0.02%) ⬆️
server/statistics/store_load.go 95.90% <100.00%> (+0.10%) ⬆️
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
server/tso/allocator_manager.go 58.04% <0.00%> (-4.98%) ⬇️
server/election/leadership.go 77.31% <0.00%> (-3.10%) ⬇️
server/tso/tso.go 67.79% <0.00%> (-2.83%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/schedulers/evict_leader.go 78.57% <0.00%> (-0.90%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df67ab...8b2c6c6. Read the comment docs.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@nolouch nolouch added require-LGT1 Indicates that the PR requires an LGTM. and removed require-LGT1 Indicates that the PR requires an LGTM. labels Jul 20, 2022
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, will it affect the HISTORY_HOT_REGIONS?

@nolouch
Copy link
Contributor

nolouch commented Jul 25, 2022

Ping @lhy1024

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 25, 2022

HISTORY_HOT_REGIONS

BTW, will it affect the HISTORY_HOT_REGIONS?

This struct does not affect the results of HistoryHotRegions, which has a separate struct and uses some functions to solve, such as

func (h *Handler) PackHistoryHotReadRegions() ([]storage.HistoryHotRegion, error) {
,
func (h *Handler) PackHistoryHotWriteRegions() ([]storage.HistoryHotRegion, error) {
, but it is possible to optimize the process

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@nolouch
Copy link
Contributor

nolouch commented Jul 26, 2022

PTAL @HunDunDM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jul 28, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1dfe189

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants