Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdctl/command: add scheduler command #537

Merged
merged 3 commits into from Feb 23, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions pdctl/command/global.go
Expand Up @@ -14,6 +14,8 @@
package command

import (
"bytes"
"encoding/json"
"fmt"
"io"
"io/ioutil"
Expand Down Expand Up @@ -139,6 +141,26 @@ func validPDAddr(pd string) error {
return nil
}

func postJSON(cmd *cobra.Command, prefix string, input map[string]interface{}) {
data, err := json.Marshal(input)
if err != nil {
fmt.Println(err)
return
}

url := getAddressFromCmd(cmd, prefix)
r, err := http.Post(url, "application/json", bytes.NewBuffer(data))
if err != nil {
fmt.Println(err)
return
}
defer r.Body.Close()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should read all r.Body, I remember if not, the connection may be leak even close the body.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any resource about why I must read r.Body, any link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we can't know whether the body has data or not.

In most of the cases, PUT returns no body, but it is still valid that PUT returns body.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the safest way here is to read body and discard it.

if r.StatusCode != http.StatusOK {
printResponseError(r)
}
}

// UsageTemplate will used to generate a help information
const UsageTemplate = `Usage:{{if .Runnable}}
{{if .HasAvailableFlags}}{{appendIfNotPresent .UseLine ""}}{{else}}{{.UseLine}}{{end}}{{end}}{{if .HasAvailableSubCommands}}
Expand Down
158 changes: 158 additions & 0 deletions pdctl/command/scheduler.go
@@ -0,0 +1,158 @@
// Copyright 2017 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package command

import (
"fmt"
"net/http"
"strconv"

"github.com/spf13/cobra"
)

var (
schedulersPrefix = "pd/api/v1/schedulers"
)

// NewSchedulerCommand returns a scheduler command.
func NewSchedulerCommand() *cobra.Command {
c := &cobra.Command{
Use: "scheduler",
Short: "show schedulers",
Run: showSchedulerCommandFunc,
}
c.AddCommand(NewAddSchedulerCommand())
c.AddCommand(NewRemoveSchedulerCommand())
return c
}

func showSchedulerCommandFunc(cmd *cobra.Command, args []string) {
if len(args) != 0 {
fmt.Println(cmd.UsageString())
return
}

r, err := doRequest(cmd, schedulersPrefix, http.MethodGet)
if err != nil {
fmt.Println(err)
return
}
fmt.Println(r)
}

// NewAddSchedulerCommand returns a command to add scheduler.
func NewAddSchedulerCommand() *cobra.Command {
c := &cobra.Command{
Use: "add <scheduler>",
Short: "add a scheduler",
}
c.AddCommand(NewGrantLeaderSchedulerCommand())
c.AddCommand(NewEvictLeaderSchedulerCommand())
c.AddCommand(NewShuffleLeaderSchedulerCommand())
c.AddCommand(NewShuffleRegionSchedulerCommand())
return c
}

// NewGrantLeaderSchedulerCommand returns a command to add a grant-leader-scheduler.
func NewGrantLeaderSchedulerCommand() *cobra.Command {
c := &cobra.Command{
Use: "grant-leader-scheduler <store_id>",
Short: "add a scheduler to grant leader to a store",
Run: addSchedulerForStoreCommandFunc,
}
return c
}

// NewEvictLeaderSchedulerCommand returns a command to add a evict-leader-scheduler.
func NewEvictLeaderSchedulerCommand() *cobra.Command {
c := &cobra.Command{
Use: "evict-leader-scheduler <store_id>",
Short: "add a scheduler to evict leader from a store",
Run: addSchedulerForStoreCommandFunc,
}
return c
}

func addSchedulerForStoreCommandFunc(cmd *cobra.Command, args []string) {
if len(args) != 1 {
fmt.Println(cmd.UsageString())
return
}

storeID, err := strconv.ParseUint(args[0], 10, 64)
if err != nil {
fmt.Println(err)
return
}

input := make(map[string]interface{})
input["name"] = cmd.Name()
input["store_id"] = storeID
postJSON(cmd, schedulersPrefix, input)
}

// NewShuffleLeaderSchedulerCommand returns a command to add a shuffle-leader-scheduler.
func NewShuffleLeaderSchedulerCommand() *cobra.Command {
c := &cobra.Command{
Use: "shuffle-leader-scheduler",
Short: "add a scheduler to shuffle leaders between stores",
Run: addSchedulerCommandFunc,
}
return c
}

// NewShuffleRegionSchedulerCommand returns a command to add a shuffle-region-scheduler.
func NewShuffleRegionSchedulerCommand() *cobra.Command {
c := &cobra.Command{
Use: "shuffle-region-scheduler",
Short: "add a scheduler to shuffle regions between stores",
Run: addSchedulerCommandFunc,
}
return c
}

func addSchedulerCommandFunc(cmd *cobra.Command, args []string) {
if len(args) != 0 {
fmt.Println(cmd.UsageString())
return
}

input := make(map[string]interface{})
input["name"] = cmd.Name()
postJSON(cmd, schedulersPrefix, input)
}

// NewRemoveSchedulerCommand returns a command to remove scheduler.
func NewRemoveSchedulerCommand() *cobra.Command {
c := &cobra.Command{
Use: "remove <scheduler>",
Short: "remove a scheduler",
Run: removeSchedulerCommandFunc,
}
return c
}

func removeSchedulerCommandFunc(cmd *cobra.Command, args []string) {
if len(args) != 1 {
fmt.Println(cmd.Usage())
return
}

path := schedulersPrefix + "/" + args[0]
_, err := doRequest(cmd, path, http.MethodDelete)
if err != nil {
fmt.Println(err)
return
}
}
1 change: 1 addition & 0 deletions pdctl/ctl.go
Expand Up @@ -43,6 +43,7 @@ func init() {
command.NewMemberCommand(),
command.NewExitCommand(),
command.NewLabelCommand(),
command.NewSchedulerCommand(),
)
cobra.EnablePrefixMatching = true
}
Expand Down