New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdctl/command: add scheduler command #537
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,158 @@ | ||
// Copyright 2017 PingCAP, Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package command | ||
|
||
import ( | ||
"fmt" | ||
"net/http" | ||
"strconv" | ||
|
||
"github.com/spf13/cobra" | ||
) | ||
|
||
var ( | ||
schedulersPrefix = "pd/api/v1/schedulers" | ||
) | ||
|
||
// NewSchedulerCommand returns a scheduler command. | ||
func NewSchedulerCommand() *cobra.Command { | ||
c := &cobra.Command{ | ||
Use: "scheduler", | ||
Short: "show schedulers", | ||
Run: showSchedulerCommandFunc, | ||
} | ||
c.AddCommand(NewAddSchedulerCommand()) | ||
c.AddCommand(NewRemoveSchedulerCommand()) | ||
return c | ||
} | ||
|
||
func showSchedulerCommandFunc(cmd *cobra.Command, args []string) { | ||
if len(args) != 0 { | ||
fmt.Println(cmd.UsageString()) | ||
return | ||
} | ||
|
||
r, err := doRequest(cmd, schedulersPrefix, http.MethodGet) | ||
if err != nil { | ||
fmt.Println(err) | ||
return | ||
} | ||
fmt.Println(r) | ||
} | ||
|
||
// NewAddSchedulerCommand returns a command to add scheduler. | ||
func NewAddSchedulerCommand() *cobra.Command { | ||
c := &cobra.Command{ | ||
Use: "add <scheduler>", | ||
Short: "add a scheduler", | ||
} | ||
c.AddCommand(NewGrantLeaderSchedulerCommand()) | ||
c.AddCommand(NewEvictLeaderSchedulerCommand()) | ||
c.AddCommand(NewShuffleLeaderSchedulerCommand()) | ||
c.AddCommand(NewShuffleRegionSchedulerCommand()) | ||
return c | ||
} | ||
|
||
// NewGrantLeaderSchedulerCommand returns a command to add a grant-leader-scheduler. | ||
func NewGrantLeaderSchedulerCommand() *cobra.Command { | ||
c := &cobra.Command{ | ||
Use: "grant-leader-scheduler <store_id>", | ||
Short: "add a scheduler to grant leader to a store", | ||
Run: addSchedulerForStoreCommandFunc, | ||
} | ||
return c | ||
} | ||
|
||
// NewEvictLeaderSchedulerCommand returns a command to add a evict-leader-scheduler. | ||
func NewEvictLeaderSchedulerCommand() *cobra.Command { | ||
c := &cobra.Command{ | ||
Use: "evict-leader-scheduler <store_id>", | ||
Short: "add a scheduler to evict leader from a store", | ||
Run: addSchedulerForStoreCommandFunc, | ||
} | ||
return c | ||
} | ||
|
||
func addSchedulerForStoreCommandFunc(cmd *cobra.Command, args []string) { | ||
if len(args) != 1 { | ||
fmt.Println(cmd.UsageString()) | ||
return | ||
} | ||
|
||
storeID, err := strconv.ParseUint(args[0], 10, 64) | ||
if err != nil { | ||
fmt.Println(err) | ||
return | ||
} | ||
|
||
input := make(map[string]interface{}) | ||
input["name"] = cmd.Name() | ||
input["store_id"] = storeID | ||
postJSON(cmd, schedulersPrefix, input) | ||
} | ||
|
||
// NewShuffleLeaderSchedulerCommand returns a command to add a shuffle-leader-scheduler. | ||
func NewShuffleLeaderSchedulerCommand() *cobra.Command { | ||
c := &cobra.Command{ | ||
Use: "shuffle-leader-scheduler", | ||
Short: "add a scheduler to shuffle leaders between stores", | ||
Run: addSchedulerCommandFunc, | ||
} | ||
return c | ||
} | ||
|
||
// NewShuffleRegionSchedulerCommand returns a command to add a shuffle-region-scheduler. | ||
func NewShuffleRegionSchedulerCommand() *cobra.Command { | ||
c := &cobra.Command{ | ||
Use: "shuffle-region-scheduler", | ||
Short: "add a scheduler to shuffle regions between stores", | ||
Run: addSchedulerCommandFunc, | ||
} | ||
return c | ||
} | ||
|
||
func addSchedulerCommandFunc(cmd *cobra.Command, args []string) { | ||
if len(args) != 0 { | ||
fmt.Println(cmd.UsageString()) | ||
return | ||
} | ||
|
||
input := make(map[string]interface{}) | ||
input["name"] = cmd.Name() | ||
postJSON(cmd, schedulersPrefix, input) | ||
} | ||
|
||
// NewRemoveSchedulerCommand returns a command to remove scheduler. | ||
func NewRemoveSchedulerCommand() *cobra.Command { | ||
c := &cobra.Command{ | ||
Use: "remove <scheduler>", | ||
Short: "remove a scheduler", | ||
Run: removeSchedulerCommandFunc, | ||
} | ||
return c | ||
} | ||
|
||
func removeSchedulerCommandFunc(cmd *cobra.Command, args []string) { | ||
if len(args) != 1 { | ||
fmt.Println(cmd.Usage()) | ||
return | ||
} | ||
|
||
path := schedulersPrefix + "/" + args[0] | ||
_, err := doRequest(cmd, path, http.MethodDelete) | ||
if err != nil { | ||
fmt.Println(err) | ||
return | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should read all r.Body, I remember if not, the connection may be leak even close the body.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any resource about why I must read
r.Body
, any link?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we can't know whether the body has data or not.
In most of the cases, PUT returns no body, but it is still valid that PUT returns body.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the safest way here is to read body and discard it.