Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the wrong store monitor #5404

Merged
merged 3 commits into from Aug 16, 2022
Merged

*: fix the wrong store monitor #5404

merged 3 commits into from Aug 16, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 5, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Close #5391.

What is changed and how does it work?

Check List

Tests

  • Manual test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

if s.regionCount < initialMaxRegionCounts && s.GetAvailable() > initialMinSpace {
// See https://github.com/tikv/pd/issues/3444 and https://github.com/tikv/pd/issues/5391
// TODO: we need find a better way to get the init region number when starting a new cluster.
if s.regionCount < InitClusterRegionThreshold && s.GetAvailable() > initialMinSpace {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe using the start time is better?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO here since using start time could also be inaccurate.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #5404 (1f66e47) into master (2825105) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 1f66e47 differs from pull request most recent head 561a26d. Consider uploading reports for the commit 561a26d to get more accurate results

@@            Coverage Diff             @@
##           master    #5404      +/-   ##
==========================================
+ Coverage   75.56%   75.60%   +0.04%     
==========================================
  Files         313      313              
  Lines       31130    31130              
==========================================
+ Hits        23523    23536      +13     
+ Misses       5590     5579      -11     
+ Partials     2017     2015       -2     
Flag Coverage Δ
unittests 75.60% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/store.go 82.43% <100.00%> (ø)
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
server/tso/tso.go 66.66% <0.00%> (-6.22%) ⬇️
pkg/dashboard/adapter/manager.go 74.71% <0.00%> (-4.60%) ⬇️
server/schedulers/random_merge.go 61.29% <0.00%> (-3.23%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/member/member.go 65.78% <0.00%> (-1.58%) ⬇️
server/server.go 74.96% <0.00%> (-0.14%) ⬇️
client/client.go 69.52% <0.00%> (-0.11%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2022
@rleungx
Copy link
Member Author

rleungx commented Aug 16, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1f66e47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3c85f11 into tikv:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The low space store is not accurate in the monitor
4 participants