Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: only keep one protobuf dependency #5406

Merged
merged 2 commits into from Aug 16, 2022
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Aug 5, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5414.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #5406 (c368773) into master (ab01355) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c368773 differs from pull request most recent head eb63b26. Consider uploading reports for the commit eb63b26 to get more accurate results

@@            Coverage Diff             @@
##           master    #5406      +/-   ##
==========================================
+ Coverage   75.65%   75.67%   +0.01%     
==========================================
  Files         313      312       -1     
  Lines       31130    31069      -61     
==========================================
- Hits        23552    23511      -41     
+ Misses       5566     5551      -15     
+ Partials     2012     2007       -5     
Flag Coverage Δ
unittests 75.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/filter/filters.go 91.64% <ø> (ø)
server/server.go 75.89% <ø> (+0.13%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/tso/local_allocator.go 62.16% <0.00%> (-13.52%) ⬇️
pkg/typeutil/conversion.go 90.47% <0.00%> (-9.53%) ⬇️
server/tso/allocator_manager.go 61.35% <0.00%> (-2.82%) ⬇️
server/tso/tso.go 70.62% <0.00%> (-2.26%) ⬇️
server/region_syncer/client.go 86.56% <0.00%> (-1.50%) ⬇️
server/election/lease.go 84.05% <0.00%> (-1.45%) ⬇️
server/tso/global_allocator.go 60.20% <0.00%> (-1.05%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-linked-issue labels Aug 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2022
@rleungx
Copy link
Member Author

rleungx commented Aug 16, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c368773

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2825105 into tikv:master Aug 16, 2022
@rleungx rleungx deleted the update-dependency branch August 16, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants