Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grcp_server: return err if cluster id is not ready . #5412

Merged
merged 3 commits into from Aug 11, 2022

Conversation

bufferflies
Copy link
Contributor

Signed-off-by: bufferflies 1045931706@qq.com

What problem does this PR solve?

Issue Number: Close #5411

What is changed and how does it work?

Check List

Tests

  • Unit test

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@bufferflies
Copy link
Contributor Author

ref: tikv/tikv#13242

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #5412 (760a107) into master (0791fe8) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 760a107 differs from pull request most recent head 9e4ded7. Consider uploading reports for the commit 9e4ded7 to get more accurate results

@@            Coverage Diff             @@
##           master    #5412      +/-   ##
==========================================
- Coverage   75.71%   75.65%   -0.07%     
==========================================
  Files         313      313              
  Lines       31101    31106       +5     
==========================================
- Hits        23549    23532      -17     
- Misses       5544     5560      +16     
- Partials     2008     2014       +6     
Flag Coverage Δ
unittests 75.65% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/grpc_service.go 48.73% <0.00%> (-1.02%) ⬇️
pkg/tempurl/tempurl.go 60.00% <0.00%> (-10.00%) ⬇️
server/election/lease.go 84.05% <0.00%> (-2.90%) ⬇️
server/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
server/schedule/hbstream/heartbeat_streams.go 72.72% <0.00%> (-2.03%) ⬇️
server/cluster/coordinator.go 71.00% <0.00%> (-1.86%) ⬇️
server/member/member.go 64.21% <0.00%> (-1.58%) ⬇️
server/region_syncer/server.go 86.26% <0.00%> (-1.10%) ⬇️
server/cluster/unsafe_recovery_controller.go 80.54% <0.00%> (-0.37%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.2 and removed do-not-merge/needs-triage-completed labels Aug 8, 2022
@nolouch nolouch removed the needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. label Aug 10, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. label Aug 11, 2022
@bufferflies
Copy link
Contributor Author

relate: tikv/tikv#13242

@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: be5af2e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2022
@ti-chi-bot
Copy link
Member

@bufferflies: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ab01355 into tikv:master Aug 11, 2022
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 11, 2022
close tikv#5411

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5419.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 11, 2022
close tikv#5411

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5420.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 11, 2022
close tikv#5411

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5421.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Aug 11, 2022
close tikv#5411

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5422.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5423.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5424.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5425.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5426.

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 11, 2022
ti-chi-bot added a commit that referenced this pull request Aug 11, 2022
close #5411, ref #5412

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: bufferflies <1045931706@qq.com>
ti-chi-bot added a commit that referenced this pull request Aug 16, 2022
close #5411, ref #5412

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: bufferflies <1045931706@qq.com>
ti-chi-bot added a commit that referenced this pull request Aug 29, 2022
close #5411, ref #5412

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: bufferflies <1045931706@qq.com>
@bufferflies bufferflies deleted the pd/panic branch September 28, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. needs-cherry-pick-release-6.1 needs-cherry-pick-release-6.2 release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: PD should return err if cluster-id is zero .
6 participants