New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grcp_server: return err if cluster id is not ready . #5412
Conversation
Signed-off-by: bufferflies <1045931706@qq.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ref: tikv/tikv#13242 |
Codecov Report
@@ Coverage Diff @@
## master #5412 +/- ##
==========================================
- Coverage 75.71% 75.65% -0.07%
==========================================
Files 313 313
Lines 31101 31106 +5
==========================================
- Hits 23549 23532 -17
- Misses 5544 5560 +16
- Partials 2008 2014 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
relate: tikv/tikv#13242 |
/merge |
@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: be5af2e
|
@bufferflies: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#5411 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5419. |
close tikv#5411 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5420. |
close tikv#5411 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5421. |
close tikv#5411 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5422. |
In response to a cherrypick label: new pull request created: #5423. |
In response to a cherrypick label: new pull request created: #5424. |
In response to a cherrypick label: new pull request created: #5425. |
In response to a cherrypick label: new pull request created: #5426. |
Signed-off-by: bufferflies 1045931706@qq.com
What problem does this PR solve?
Issue Number: Close #5411
What is changed and how does it work?
Check List
Tests
Unit test
Manual test (add detailed scripts or steps below)
Code changes
Side effects
Related changes
Release note