Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: adjust log file to tiup playground #5445

Merged
merged 1 commit into from Aug 22, 2022

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Aug 19, 2022

Signed-off-by: bufferflies 1045931706@qq.com

What problem does this PR solve?

Issue Number: Close #5444

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

None

Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@bufferflies bufferflies changed the title simulator: adjust log file to tiup palyground simulator: adjust log file to tiup playground Aug 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2022
@bufferflies bufferflies added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 19, 2022
@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1661fcb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2022
@nolouch
Copy link
Contributor

nolouch commented Aug 19, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor

lhy1024 commented Aug 19, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #5445 (1661fcb) into master (6d883d0) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5445      +/-   ##
==========================================
+ Coverage   75.61%   75.74%   +0.12%     
==========================================
  Files         313      313              
  Lines       31143    31143              
==========================================
+ Hits        23548    23588      +40     
+ Misses       5581     5550      -31     
+ Partials     2014     2005       -9     
Flag Coverage Δ
unittests 75.74% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/client.go 69.52% <ø> (+0.10%) ⬆️
pkg/autoscaling/calculation.go 58.41% <ø> (ø)
pkg/etcdutil/etcdutil.go 88.37% <ø> (+5.81%) ⬆️
server/config/config.go 78.13% <ø> (ø)
server/schedule/region_scatterer.go 80.16% <ø> (ø)
server/schedule/region_splitter.go 69.52% <ø> (ø)
server/storage/kv/etcd_kv.go 79.71% <ø> (ø)
server/tso/allocator_manager.go 62.85% <ø> (+0.99%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/id/id.go 80.76% <0.00%> (-3.85%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1661fcb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@bufferflies
Copy link
Contributor Author

/run-check-issue-triage-complete

@bufferflies
Copy link
Contributor Author

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot merged commit c0d8a1b into tikv:master Aug 22, 2022
@bufferflies bufferflies deleted the simulator/log branch August 22, 2022 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulator should retry if pd server is not ready.
5 participants