Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix anticount and cold peer statistics #5479

Merged
merged 7 commits into from Sep 13, 2022

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 8, 2022

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Issue Number: Close #5478

What is changed and how does it work?

  1. The cold peer needs to wait the same time as the cooling interval before being activated again

  2. For unreported peers, the padding load uses 0 instead of the threshold

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Yui-Song
Copy link

Yui-Song commented Sep 8, 2022

/run-build-arm64 comment=true

@nolouch
Copy link
Contributor

nolouch commented Sep 8, 2022

@lhy1024 ci failed.

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 8, 2022

/run-build-arm64 comment=true

2 similar comments
@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 8, 2022

/run-build-arm64 comment=true

@purelind
Copy link
Contributor

purelind commented Sep 8, 2022

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Sep 8, 2022

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 75.67% // Head: 75.64% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0e7e31b) compared to base (86262da).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5479      +/-   ##
==========================================
- Coverage   75.67%   75.64%   -0.03%     
==========================================
  Files         320      320              
  Lines       31640    31642       +2     
==========================================
- Hits        23944    23937       -7     
- Misses       5640     5648       +8     
- Partials     2056     2057       +1     
Flag Coverage Δ
unittests 75.64% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/statistics/hot_peer.go 97.01% <100.00%> (+0.13%) ⬆️
server/statistics/hot_peer_cache.go 96.91% <100.00%> (-0.02%) ⬇️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/tso/allocator_manager.go 62.50% <0.00%> (-1.79%) ⬇️
server/region_syncer/client.go 86.56% <0.00%> (-1.50%) ⬇️
server/tso/tso.go 69.66% <0.00%> (-1.13%) ⬇️
server/region_syncer/server.go 86.26% <0.00%> (-1.10%) ⬇️
server/schedule/operator/step.go 77.77% <0.00%> (-0.86%) ⬇️
server/cluster/coordinator.go 71.00% <0.00%> (-0.56%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 13, 2022
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e7e31b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2022
@ti-chi-bot ti-chi-bot merged commit 772c480 into tikv:master Sep 13, 2022
lhy1024 added a commit to lhy1024/pd that referenced this pull request Sep 13, 2022
close tikv#5478

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: 混沌DM <hundundm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

statistics: hot peer cache contains unexpected data when cold peer and hot peer appear alternately
7 participants