New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix TestWatchKeyspace #5493
Conversation
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @rleungx |
Codecov ReportBase: 75.62% // Head: 75.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5493 +/- ##
==========================================
- Coverage 75.62% 75.58% -0.04%
==========================================
Files 320 320
Lines 31622 31622
==========================================
- Hits 23913 23901 -12
- Misses 5645 5668 +23
+ Partials 2064 2053 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 947662e
|
@AmoebaProtozoa: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Close #5481
What is changed and how does it work?
The original
TestWatchKeyspace
attempts to flush the testSuite storage by manually callingTearDownSuite
and thenSetupSuite
, which causes the testSuite to be unstable.This PR makes
TestWatchKeyspace
compare expected and actual result usingre.Contains
instead of doing direct indexed comparison, thus making flushing the storage unnecessary.Check List
Tests
Release note