Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade etcd to v3.4.21 #5519

Merged
merged 2 commits into from Sep 16, 2022
Merged

*: upgrade etcd to v3.4.21 #5519

merged 2 commits into from Sep 16, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 16, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5520

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note The PR should write the release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 75.60% // Head: 75.64% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (a1aef9d) compared to base (eeb5d3f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5519      +/-   ##
==========================================
+ Coverage   75.60%   75.64%   +0.03%     
==========================================
  Files         320      320              
  Lines       31847    31847              
==========================================
+ Hits        24078    24090      +12     
+ Misses       5694     5688       -6     
+ Partials     2075     2069       -6     
Flag Coverage Δ
unittests 75.64% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
server/id/id.go 83.05% <0.00%> (-6.78%) ⬇️
pkg/dashboard/adapter/manager.go 77.01% <0.00%> (-2.30%) ⬇️
server/storage/endpoint/meta.go 63.63% <0.00%> (-2.28%) ⬇️
server/election/lease.go 85.50% <0.00%> (-1.45%) ⬇️
pkg/btree/btree.go 86.26% <0.00%> (-0.97%) ⬇️
server/schedule/operator_controller.go 86.42% <0.00%> (-0.91%) ⬇️
server/schedule/operator/step.go 77.77% <0.00%> (-0.86%) ⬇️
server/server.go 75.31% <0.00%> (-0.13%) ⬇️
server/cluster/cluster.go 83.00% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added release-note-none and removed release-note The PR should write the release note. do-not-merge/needs-linked-issue labels Sep 16, 2022
@rleungx rleungx marked this pull request as ready for review September 16, 2022 06:26
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 16, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 65243a0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants