New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule: Fix possible nil pointer when getting command #5542
Conversation
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 75.45% // Head: 75.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5542 +/- ##
==========================================
+ Coverage 75.45% 75.56% +0.10%
==========================================
Files 326 326
Lines 32282 32275 -7
==========================================
+ Hits 24358 24388 +30
+ Misses 5813 5773 -40
- Partials 2111 2114 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
need some tests. |
It's covered by the test now |
/merge |
@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 9a0af2c
|
@Connor1996: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created: #5547. |
Signed-off-by: Connor1996 zbk602423539@gmail.com
What problem does this PR solve?
Issue Number: Close #5540
What is changed and how does it work?
Keep the behavior as previous
Check List
Tests
Related changes
Release note