Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: Fix possible nil pointer when getting command #5542

Merged
merged 2 commits into from Sep 22, 2022

Conversation

Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Sep 22, 2022

Signed-off-by: Connor1996 zbk602423539@gmail.com

What problem does this PR solve?

Issue Number: Close #5540

What is changed and how does it work?

Keep the behavior as previous

Fix possible nil pointer when getting command

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

None

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 75.45% // Head: 75.56% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (9a0af2c) compared to base (0f44e87).
Patch has no changes to coverable lines.

❗ Current head 9a0af2c differs from pull request most recent head 108d631. Consider uploading reports for the commit 108d631 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5542      +/-   ##
==========================================
+ Coverage   75.45%   75.56%   +0.10%     
==========================================
  Files         326      326              
  Lines       32282    32275       -7     
==========================================
+ Hits        24358    24388      +30     
+ Misses       5813     5773      -40     
- Partials     2111     2114       +3     
Flag Coverage Δ
unittests 75.56% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/operator/step.go 81.73% <ø> (+3.96%) ⬆️
pkg/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
server/id/id.go 83.05% <0.00%> (-6.78%) ⬇️
server/storage/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
pkg/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
server/election/lease.go 84.05% <0.00%> (-2.90%) ⬇️
pkg/dashboard/adapter/manager.go 79.31% <0.00%> (-2.30%) ⬇️
server/server.go 73.54% <0.00%> (-1.65%) ⬇️
server/cluster/cluster.go 82.58% <0.00%> (-0.36%) ⬇️
server/schedulers/balance_region.go 87.24% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2022
@nolouch
Copy link
Contributor

nolouch commented Sep 22, 2022

need some tests.

@Connor1996
Copy link
Member Author

need some tests.

It's covered by the test now

@Connor1996
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9a0af2c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2022
@ti-chi-bot
Copy link
Member

@Connor1996: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5547.

ti-chi-bot added a commit that referenced this pull request Sep 22, 2022
close #5540, ref #5542

Fix possible nil pointer when getting command

Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Co-authored-by: Connor1996 <zbk602423539@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.3 release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid memory address or nil pointer dereference
5 participants