Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: refine the operator priority #5575

Merged
merged 5 commits into from Oct 12, 2022
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 9, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Close #5388

What is changed and how does it work?

This PR does the following things:

  1. For admin operators, which are added through HTTP API. We change it from High to Urgent priority. The urgent operators will also pass the store limit check.
  2. For evict leader operators, which are used in the update cluster process or created by adding evict-leader-scheduler manually. We also change it from High to Urgent priority.
  3. For shuffle leader/shuffle region/random merge operators, which are only used in the testing environment, we change them from High to Low priority.
  4. For balance hot region/leader operators which are used to reduce the hot spot problem, we use High priority.
  5. For replica operators, created by the rule checker, like placement rule related operators, we use High priority.
  6. The others, like balance leader/balance region/merge operators. use Medium priority.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note The PR should write the release note. labels Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 75.75% // Head: 75.71% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (e4eacfd) compared to base (d50e5fe).
Patch coverage: 95.00% of modified lines in pull request are covered.

❗ Current head e4eacfd differs from pull request most recent head 107c6b0. Consider uploading reports for the commit 107c6b0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5575      +/-   ##
==========================================
- Coverage   75.75%   75.71%   -0.05%     
==========================================
  Files         326      326              
  Lines       32243    32249       +6     
==========================================
- Hits        24427    24416      -11     
- Misses       5707     5728      +21     
+ Partials     2109     2105       -4     
Flag Coverage Δ
unittests 75.71% <95.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/kind.go 61.90% <ø> (ø)
server/schedulers/grant_hot_region.go 58.67% <0.00%> (-0.31%) ⬇️
server/schedule/checker/joint_state_checker.go 57.89% <100.00%> (ø)
server/schedule/checker/replica_checker.go 69.28% <100.00%> (ø)
server/schedule/checker/rule_checker.go 80.28% <100.00%> (ø)
server/schedule/operator/operator.go 95.00% <100.00%> (ø)
server/schedule/operator_controller.go 87.16% <100.00%> (-0.17%) ⬇️
server/schedule/region_scatterer.go 79.91% <100.00%> (ø)
server/schedulers/evict_leader.go 78.57% <100.00%> (ø)
server/schedulers/grant_leader.go 66.29% <100.00%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

server/core/kind.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added release-note-none and removed do-not-merge/needs-linked-issue release-note The PR should write the release note. labels Oct 10, 2022
@rleungx rleungx marked this pull request as ready for review October 10, 2022 03:52
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2022
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
server/schedulers/grant_leader.go Show resolved Hide resolved
server/schedulers/evict_leader.go Outdated Show resolved Hide resolved
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2022
@nolouch
Copy link
Contributor

nolouch commented Oct 12, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e4eacfd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 6c76647 into tikv:master Oct 12, 2022
@rleungx rleungx deleted the op-priority branch October 12, 2022 06:08
ti-chi-bot added a commit that referenced this pull request Mar 30, 2023
close #6145

1. create new filter to pick the store who's snapshot sender is available.
2. store limit level is same with the operator level , the level is defined in this [pr](#5575)

Signed-off-by: bufferflies <1045931706@qq.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support more accurate operator priority
4 participants