Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix unstable test TestMinResolvedTS #5669

Merged
merged 2 commits into from Nov 2, 2022
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 2, 2022

What problem does this PR solve?

Issue Number: Close #5589

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

 None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 75.72% // Head: 75.73% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9987424) compared to base (72e558e).
Patch has no changes to coverable lines.

❗ Current head 9987424 differs from pull request most recent head 8eae9a8. Consider uploading reports for the commit 8eae9a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5669      +/-   ##
==========================================
+ Coverage   75.72%   75.73%   +0.01%     
==========================================
  Files         328      328              
  Lines       32560    32560              
==========================================
+ Hits        24655    24659       +4     
+ Misses       5792     5782      -10     
- Partials     2113     2119       +6     
Flag Coverage Δ
unittests 75.73% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
server/api/diagnostic.go 76.92% <0.00%> (-23.08%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
pkg/dashboard/adapter/manager.go 74.71% <0.00%> (-6.90%) ⬇️
server/storage/kv/etcd_kv.go 79.71% <0.00%> (-5.80%) ⬇️
server/cluster/diagnostic_manager.go 72.04% <0.00%> (-4.31%) ⬇️
server/schedule/hbstream/heartbeat_streams.go 72.72% <0.00%> (-2.03%) ⬇️
server/schedule/operator_controller.go 86.26% <0.00%> (-1.13%) ⬇️
server/schedule/operator/step.go 74.48% <0.00%> (-0.77%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 2, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8eae9a8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2022
@ti-chi-bot ti-chi-bot merged commit d407cae into tikv:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestMinResolvedTS is not stable
4 participants