tools: support triggering an event through HTTP API #5677

rleungx · 2022-11-03T10:58:14Z

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5468, close #5451.

What is changed and how does it work?

This PR supports the following functionality. And it can be reviewed until #5670 is merged.

random down a store through curl <ip>:<status_port>/event\?event=down-node
scale out a new store through curl <ip>:<status_port>/event\?event=add-node

Check List

Tests

Manual test

Release note

None

ti-chi-bot · 2022-11-03T10:58:15Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-11-03T11:07:44Z

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 77.33%. Comparing base (632cda4) to head (8b47279).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5677   +/-   ##
=======================================
  Coverage   77.32%   77.33%           
=======================================
  Files         470      471    +1     
  Lines       61340    61347    +7     
=======================================
+ Hits        47431    47441   +10     
- Misses      10331    10336    +5     
+ Partials     3578     3570    -8

Flag	Coverage Δ
unittests	`77.33% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

lilinghai

if we delete the delete/add nodes case ， which case based we test this scenarios ？

tools/pd-simulator/simulator/event.go

lilinghai · 2022-11-25T08:22:04Z

tools/pd-simulator/simulator/cases/cases.go

-
-// IDAllocator is used to alloc unique ID.
-var IDAllocator idAllocator
-
 // CaseMap is a mapping of the cases to the their corresponding initialize functions.
 var CaseMap = map[string]func() *Case{
 	"balance-leader":            newBalanceLeader,
 	"redundant-balance-region":  newRedundantBalanceRegion,


by the way ,why not balance region case registered?

lilinghai · 2022-11-25T08:26:25Z

tools/pd-simulator/simulator/cases/balance_region.go

@@ -36,7 +36,7 @@ func newRedundantBalanceRegion() *Case {

 	for i := 0; i < storeNum; i++ {


if we add/down-node the case checker should check all the stores balance , but it still use storeNum.
it may exists somewhere else.

lilinghai

LGTM

ti-chi-bot · 2022-12-13T07:49:24Z

@lilinghai: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-12T13:51:53Z

@rleungx: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tools/pd-simulator/simulator/simutil/id.go

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx · 2024-05-31T04:27:46Z

/merge

ti-chi-bot · 2024-05-31T04:27:48Z

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-05-31T04:27:50Z

This pull request has been accepted and is ready to merge.

Commit hash: 8b47279

ti-chi-bot added the release-note-none label Nov 3, 2022

ti-chi-bot requested review from disksing and HunDunDM November 3, 2022 10:58

rleungx requested review from nolouch and bufferflies and removed request for disksing and HunDunDM November 3, 2022 11:01

rleungx force-pushed the event branch from 96d0b81 to 47af78a Compare November 3, 2022 11:08

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2022

rleungx force-pushed the event branch from 47af78a to 47772ea Compare November 23, 2022 03:54

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2022

lilinghai reviewed Nov 25, 2022

View reviewed changes

rleungx force-pushed the event branch from 47772ea to 43287f7 Compare December 7, 2022 08:31

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2022

rleungx force-pushed the event branch from 43287f7 to c22b11e Compare December 12, 2022 04:49

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2022

lilinghai approved these changes Dec 13, 2022

View reviewed changes

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023

rleungx force-pushed the event branch from c22b11e to 36f2cbd Compare May 30, 2024 06:35

ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 30, 2024

rleungx removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2024

rleungx requested a review from HuSharp May 30, 2024 06:36

HuSharp reviewed May 30, 2024

View reviewed changes

tools/pd-simulator/simulator/simutil/id.go Show resolved Hide resolved

rleungx closed this May 30, 2024

rleungx reopened this May 30, 2024

support triggering an event through HTTP API

285a8c3

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added 5 commits May 30, 2024 18:07

address comments

3d21551

Signed-off-by: Ryan Leung <rleungx@gmail.com>

resolve the conflicts

b83b6aa

Signed-off-by: Ryan Leung <rleungx@gmail.com>

fix

0a2e8dd

Signed-off-by: Ryan Leung <rleungx@gmail.com>

add license

fce3e0e

Signed-off-by: Ryan Leung <rleungx@gmail.com>

resolve the conflicts

8b47279

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx force-pushed the event branch from 074d5f8 to 8b47279 Compare May 30, 2024 10:22

HuSharp approved these changes May 31, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2024

rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label May 31, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2024

ti-chi-bot bot merged commit 19c9852 into tikv:master May 31, 2024
17 of 19 checks passed

rleungx deleted the event branch May 31, 2024 04:28

HuSharp mentioned this pull request Jun 6, 2024

Make simulator Great Again! #8135

Open

HuSharp mentioned this pull request Jun 18, 2024

delete node and make up down replica need to be distinguished #1776

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: support triggering an event through HTTP API #5677

tools: support triggering an event through HTTP API #5677

rleungx commented Nov 3, 2022 •

edited

Loading

ti-chi-bot commented Nov 3, 2022 •

edited by ti-chi-bot bot

Loading

codecov bot commented Nov 3, 2022 •

edited

Loading

lilinghai left a comment

lilinghai Nov 25, 2022

lilinghai Nov 25, 2022

lilinghai left a comment

ti-chi-bot commented Dec 13, 2022

ti-chi-bot commented Jan 12, 2023

rleungx commented May 31, 2024

ti-chi-bot bot commented May 31, 2024

ti-chi-bot bot commented May 31, 2024

		@@ -36,7 +36,7 @@ func newRedundantBalanceRegion() *Case {

		for i := 0; i < storeNum; i++ {

tools: support triggering an event through HTTP API #5677

tools: support triggering an event through HTTP API #5677

Conversation

rleungx commented Nov 3, 2022 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Nov 3, 2022 • edited by ti-chi-bot bot Loading

codecov bot commented Nov 3, 2022 • edited Loading

Codecov Report

lilinghai left a comment

Choose a reason for hiding this comment

lilinghai Nov 25, 2022

Choose a reason for hiding this comment

lilinghai Nov 25, 2022

Choose a reason for hiding this comment

lilinghai left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Dec 13, 2022

ti-chi-bot commented Jan 12, 2023

rleungx commented May 31, 2024

ti-chi-bot bot commented May 31, 2024

ti-chi-bot bot commented May 31, 2024

rleungx commented Nov 3, 2022 •

edited

Loading

ti-chi-bot commented Nov 3, 2022 •

edited by ti-chi-bot bot

Loading

codecov bot commented Nov 3, 2022 •

edited

Loading