Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: the implement of server #5761

Closed
wants to merge 4 commits into from

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Dec 7, 2022

What problem does this PR solve?

Issue Number: Close #4399

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

Please add a release note.

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with None.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note The PR should write the release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2022
@nolouch nolouch force-pushed the resource-manager/server branch 2 times, most recently from 35bc02c to 5fadf2d Compare December 8, 2022 18:59
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 75.57% // Head: 75.52% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (3ab96a1) compared to base (8227cdb).
Patch coverage: 76.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5761      +/-   ##
==========================================
- Coverage   75.57%   75.52%   -0.06%     
==========================================
  Files         329      331       +2     
  Lines       32965    32984      +19     
==========================================
- Hits        24914    24911       -3     
- Misses       5902     5920      +18     
- Partials     2149     2153       +4     
Flag Coverage Δ
unittests 75.52% <76.92%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/endpoint/key_path.go 90.90% <0.00%> (-2.12%) ⬇️
server/storage/endpoint/resource_group.go 0.00% <0.00%> (ø)
server/storage/storage.go 67.30% <ø> (-3.85%) ⬇️
pkg/mcs/resource_manager/client/client.go 75.00% <75.00%> (ø)
server/server.go 74.87% <88.88%> (-1.02%) ⬇️
pkg/dashboard/adapter/manager.go 74.71% <0.00%> (-4.60%) ⬇️
server/region_syncer/server.go 82.96% <0.00%> (-4.40%) ⬇️
pkg/utils/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
server/schedulers/shuffle_hot_region.go 55.12% <0.00%> (-2.57%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nolouch nolouch force-pushed the resource-manager/server branch 2 times, most recently from 81849e5 to ee0f823 Compare December 11, 2022 19:33
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch changed the title [WIP] resource_manager: add basic implement resource_manager: add basic implement Dec 13, 2022
@lhy1024 lhy1024 self-requested a review December 14, 2022 06:11
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2022
@ti-chi-bot
Copy link
Member

@nolouch: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nolouch nolouch changed the title resource_manager: add basic implement resource_manager: the implement of server Dec 15, 2022
@nolouch nolouch closed this Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note The PR should write the release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue
2 participants