schedulers: add balance witness scheduler #5763

ethercflow · 2022-12-07T11:41:28Z

Signed-off-by: Wenbo Zhang ethercflow@gmail.com

What problem does this PR solve?

Issue Number: Close #5762

What is changed and how does it work?

schedulers: add balance witness scheduler

Check List

Tests

Integration test

Code changes

Has configuration change
Has HTTP API interfaces changed
Has persistent data change

Side effects

Increased code complexity

Related changes

PR to update pingcap/docs/pingcap/docs-cn:

Release note

schedulers: add balance witness scheduler

ti-chi-bot · 2022-12-07T11:41:30Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Connor1996
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

lhy1024 · 2022-12-08T02:34:42Z

ci failed

server/schedulers/balance_witness_test.go

server/schedulers/balance_witness.go

server/schedulers/utils.go

server/core/region_tree.go

server/schedule/filter/counter.go

server/schedulers/utils.go

server/schedule/operator/step.go

ti-chi-bot · 2022-12-09T08:30:29Z

@ethercflow: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2022-12-09T11:11:42Z

Codecov Report

Base: 75.47% // Head: 75.55% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (8b9b751) compared to base (218e8cb).
Patch coverage: 72.30% of modified lines in pull request are covered.

❗ Current head 8b9b751 differs from pull request most recent head 79613a3. Consider uploading reports for the commit 79613a3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5763      +/-   ##
==========================================
+ Coverage   75.47%   75.55%   +0.07%     
==========================================
  Files         337      338       +1     
  Lines       33262    33580     +318     
==========================================
+ Hits        25106    25372     +266     
- Misses       5980     6024      +44     
- Partials     2176     2184       +8

Flag	Coverage Δ
unittests	`75.55% <72.30%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/api/scheduler.go	`41.11% <0.00%> (-0.86%)`	⬇️
server/core/kind.go	`59.09% <0.00%> (-2.82%)`	⬇️
server/handler.go	`52.98% <0.00%> (-0.11%)`	⬇️
server/schedule/filter/counter.go	`87.50% <ø> (ø)`
server/schedule/operator/kind.go	`100.00% <ø> (ø)`
server/cluster/cluster.go	`81.40% <50.00%> (-0.06%)`	⬇️
server/schedule/filter/filters.go	`87.95% <64.51%> (-2.23%)`	⬇️
server/schedulers/balance_witness.go	`65.94% <65.94%> (ø)`
server/schedule/operator/step.go	`76.99% <69.23%> (+3.89%)`	⬆️
server/core/region.go	`89.66% <77.27%> (-0.38%)`	⬇️
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

server/core/region.go

server/schedulers/balance_witness.go

Connor1996

LGTM

bufferflies · 2022-12-27T02:46:50Z

maybe, you can devide the big pr into some small pr such as pd-ctl , http , scheduler .

close tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

ethercflow · 2022-12-27T06:37:51Z

maybe, you can devide the big pr into some small pr such as pd-ctl , http , scheduler .

Got it, thanks!

server/schedule/operator/step.go

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

server/schedulers/metrics.go

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

ethercflow · 2022-12-28T11:58:23Z

/test build

wuhuizuo · 2022-12-28T12:10:12Z

/retest

wuhuizuo · 2022-12-28T12:33:37Z

/retest

bufferflies · 2022-12-29T02:42:04Z

server/schedulers/balance_region.go

@@ -191,21 +189,21 @@ func (s *balanceRegionScheduler) Schedule(cluster schedule.Cluster, dryRun bool)
 			// Priority pick the region that has a pending peer.
 			// Pending region may mean the disk is overload, remove the pending region firstly.
 			solver.region = filter.SelectOneRegion(cluster.RandPendingRegions(solver.SourceStoreID(), s.conf.Ranges), collector,
-				baseRegionFilters...)
+				append(baseRegionFilters, filter.NewRegionWitnessFilter(solver.SourceStoreID()))...)


how about add NewRegionWitnessFilter to base region filters ?

I don't think it can, because solver.SourceStoreID() needs to be passed as a parameter, and the solver is obtained by traversing sourceStores.

rleungx

Mostly, LGTM

nolouch · 2022-12-30T05:58:16Z

/merge

ti-chi-bot · 2022-12-30T05:58:17Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-12-30T05:58:19Z

This pull request has been accepted and is ready to merge.

Commit hash: 8b9b751

ti-chi-bot · 2022-12-30T05:58:32Z

@ethercflow: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added release-note The PR should write the release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 7, 2022

ti-chi-bot requested review from lhy1024 and rleungx December 7, 2022 11:41

ethercflow marked this pull request as ready for review December 7, 2022 11:50

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2022

rleungx reviewed Dec 8, 2022

View reviewed changes

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2022

ethercflow force-pushed the balance-witness branch from 4c5eb07 to 0a352b3 Compare December 9, 2022 09:48

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2022

ethercflow force-pushed the balance-witness branch from 0a352b3 to d25aa52 Compare December 9, 2022 10:10

ethercflow requested review from rleungx and removed request for lhy1024 December 9, 2022 11:14

rleungx reviewed Dec 12, 2022

View reviewed changes

server/core/region.go Show resolved Hide resolved

server/schedulers/balance_witness.go Outdated Show resolved Hide resolved

Connor1996 mentioned this pull request Dec 13, 2022

Support 2 Replicas With 1 Log Only Mechanism tikv/tikv#12876

Open

38 tasks

Connor1996 approved these changes Dec 13, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 13, 2022

ethercflow requested a review from rleungx December 27, 2022 02:06

ethercflow added 5 commits December 27, 2022 14:24

schedulers: add balance witness scheduler

987f256

close tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

fix panic caused by nil pointer

f0dbcd8

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

fix scheduler related tests

3fdd240

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

address comments

9a53c12

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

fix compile error caused by old dep

f1aa9c0

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

ethercflow force-pushed the balance-witness branch from 52ddcae to f1aa9c0 Compare December 27, 2022 06:37

rleungx reviewed Dec 27, 2022

View reviewed changes

server/schedule/operator/step.go Show resolved Hide resolved

ethercflow added 2 commits December 27, 2022 16:26

filter witness peer when balance region

f819315

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

adjuest step cost

f72ed93

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

ethercflow force-pushed the balance-witness branch from a2258e8 to f72ed93 Compare December 27, 2022 09:13

rleungx reviewed Dec 27, 2022

View reviewed changes

server/schedulers/metrics.go Show resolved Hide resolved

register metrics and adjust brief

8b9b751

ref tikv#5762 Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>

ethercflow requested a review from rleungx December 28, 2022 12:00

bufferflies reviewed Dec 29, 2022

View reviewed changes

rleungx approved these changes Dec 29, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 29, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2022

Merge branch 'master' into balance-witness

79613a3

ti-chi-bot merged commit 5a4ccbe into tikv:master Dec 30, 2022

Connor1996 mentioned this pull request Jan 16, 2023

core: Introduce balance witness scheduler #5285

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

schedulers: add balance witness scheduler #5763

schedulers: add balance witness scheduler #5763

ethercflow commented Dec 7, 2022

ti-chi-bot commented Dec 7, 2022 •

edited

lhy1024 commented Dec 8, 2022

ti-chi-bot commented Dec 9, 2022

codecov bot commented Dec 9, 2022 •

edited

Connor1996 left a comment

bufferflies commented Dec 27, 2022

ethercflow commented Dec 27, 2022

ethercflow commented Dec 28, 2022

wuhuizuo commented Dec 28, 2022

wuhuizuo commented Dec 28, 2022

bufferflies Dec 29, 2022 •

edited

ethercflow Dec 29, 2022 •

edited

rleungx left a comment

nolouch commented Dec 30, 2022

ti-chi-bot commented Dec 30, 2022

ti-chi-bot commented Dec 30, 2022

ti-chi-bot commented Dec 30, 2022

schedulers: add balance witness scheduler #5763

schedulers: add balance witness scheduler #5763

Conversation

ethercflow commented Dec 7, 2022

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Dec 7, 2022 • edited

lhy1024 commented Dec 8, 2022

ti-chi-bot commented Dec 9, 2022

codecov bot commented Dec 9, 2022 • edited

Codecov Report

Connor1996 left a comment

Choose a reason for hiding this comment

bufferflies commented Dec 27, 2022

ethercflow commented Dec 27, 2022

ethercflow commented Dec 28, 2022

wuhuizuo commented Dec 28, 2022

wuhuizuo commented Dec 28, 2022

bufferflies Dec 29, 2022 • edited

Choose a reason for hiding this comment

ethercflow Dec 29, 2022 • edited

Choose a reason for hiding this comment

rleungx left a comment

Choose a reason for hiding this comment

nolouch commented Dec 30, 2022

ti-chi-bot commented Dec 30, 2022

ti-chi-bot commented Dec 30, 2022

ti-chi-bot commented Dec 30, 2022

ti-chi-bot commented Dec 7, 2022 •

edited

codecov bot commented Dec 9, 2022 •

edited

bufferflies Dec 29, 2022 •

edited

ethercflow Dec 29, 2022 •

edited