Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: update Go version, wording #5777

Merged
merged 4 commits into from Dec 13, 2022
Merged

readme: update Go version, wording #5777

merged 4 commits into from Dec 13, 2022

Conversation

Oreoxmt
Copy link
Contributor

@Oreoxmt Oreoxmt commented Dec 13, 2022

Signed-off-by: Aolin aolin.zhang@pingcap.com

What problem does this PR solve?

Issue Number: Close #5776

What is changed and how does it work?

* update the Go version to v1.19
* update some old links to the latest one
* update some wording, format, and the output of command

Check List

Tests

  • No code

Related changes

Release note

None

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 13, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Oreoxmt
Copy link
Contributor Author

Oreoxmt commented Dec 13, 2022

/cc @nolouch @lilin90

@ti-chi-bot
Copy link
Member

@Oreoxmt: GitHub didn't allow me to request PR reviews from the following users: lilin90.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @nolouch @lilin90

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 13, 2022
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@lilin90: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Dec 13, 2022
@rleungx
Copy link
Member

rleungx commented Dec 13, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dc66545

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 75.65% // Head: 75.65% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (dc66545) compared to base (65abc36).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5777   +/-   ##
=======================================
  Coverage   75.65%   75.65%           
=======================================
  Files         329      329           
  Lines       32961    32961           
=======================================
+ Hits        24936    24937    +1     
+ Misses       5883     5877    -6     
- Partials     2142     2147    +5     
Flag Coverage Δ
unittests 75.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/utils/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/id/id.go 83.05% <0.00%> (-6.78%) ⬇️
server/schedulers/random_merge.go 62.50% <0.00%> (-3.13%) ⬇️
pkg/encryption/key_manager.go 70.11% <0.00%> (-1.60%) ⬇️
server/member/member.go 62.10% <0.00%> (-1.58%) ⬇️
server/region_syncer/client.go 85.07% <0.00%> (-1.50%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/tso/tso.go 69.66% <0.00%> (-1.13%) ⬇️
server/server.go 74.53% <0.00%> (-0.75%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot merged commit 16fb017 into tikv:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Go version in readme is not consistent with go.mod
4 participants