*: move core to pkg

[rleungx]

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #5838.

What is changed and how does it work?

This PR does the following things:

• move package core from server to pkg
• delete operator/test_util.go and core/test_util.go
• merge newTestRegionInfo in api package and NewTestRegionInfo in core package
• adjust some tests and remove unused functions

Check List

Tests

• Unit test

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• CabinfeverB
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Base: 74.96% // Head: 74.95% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bc2e9ce) compared to base (bac5bf4).
Patch coverage: 92.78% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5781      +/-   ##
==========================================
- Coverage   74.96%   74.95%   -0.02%     
==========================================
  Files         337      335       -2     
  Lines       34065    34030      -35     
==========================================
- Hits        25536    25506      -30     
+ Misses       6341     6337       -4     
+ Partials     2188     2187       -1     

Flag	Coverage Δ
unittests	74.95% <92.78%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/autoscaling/calculation.go	58.41% <ø> (ø)
pkg/core/basic_cluster.go	93.33% <ø> (ø)
pkg/core/factory.go	100.00% <ø> (ø)
pkg/core/kind.go	59.09% <ø> (ø)
pkg/core/peer.go	96.55% <ø> (ø)
pkg/core/rangetree/range_tree.go	61.81% <ø> (ø)
pkg/core/region_tree.go	95.56% <ø> (ø)
pkg/core/store_option.go	100.00% <ø> (ø)
pkg/core/store_stats.go	75.00% <ø> (ø)
pkg/core/storelimit/store_limit.go	87.09% <ø> (ø)
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[nolouch]

Does the core package need to provided to the third party?

[rleungx]

Does the core package need to provided to the third party?

Do you mean to use an individual mod?

[nolouch]

Noop, just suspect really need to move？

[rleungx]

Noop, just suspect really need to move？

I think these definitions will be shared by multiple services so that moving them out will be more clear.

[nolouch]

lgtm

[rleungx]

/merge

[ti-chi-bot]

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: bc2e9ce

[binshi-bing]

reviewed