Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix versioninfo path #5782

Merged
merged 1 commit into from Dec 15, 2022
Merged

*: fix versioninfo path #5782

merged 1 commit into from Dec 15, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 15, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Close #5783.

What is changed and how does it work?

Check List

Tests

  • No code

Release note

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@rleungx rleungx changed the title *: fix versioninfo path *: fix versioninfo path Dec 15, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 15, 2022
@rleungx
Copy link
Member Author

rleungx commented Dec 15, 2022

/check-issue-triage-complete

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 75.56% // Head: 75.65% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (01d1ac3) compared to base (ad1cc2d).
Patch coverage: 77.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5782      +/-   ##
==========================================
+ Coverage   75.56%   75.65%   +0.08%     
==========================================
  Files         329      330       +1     
  Lines       32961    32992      +31     
==========================================
+ Hits        24907    24960      +53     
+ Misses       5900     5887      -13     
+ Partials     2154     2145       -9     
Flag Coverage Δ
unittests 75.65% <77.27%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/autoscaling/service.go 100.00% <ø> (ø)
pkg/dashboard/dashboard.go 90.00% <ø> (ø)
pkg/id/id.go 89.83% <ø> (ø)
pkg/id/metrics.go 100.00% <ø> (ø)
pkg/mock/mockcluster/mockcluster.go 93.94% <ø> (ø)
pkg/storage/endpoint/config.go 76.47% <ø> (ø)
pkg/storage/endpoint/endpoint.go 100.00% <ø> (ø)
pkg/storage/endpoint/external_timestamp.go 55.55% <ø> (ø)
pkg/storage/endpoint/gc_key_space.go 66.66% <ø> (ø)
pkg/storage/endpoint/gc_safe_point.go 70.83% <ø> (ø)
... and 82 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rleungx
Copy link
Member Author

rleungx commented Dec 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 01d1ac3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 15, 2022
@ti-chi-bot ti-chi-bot merged commit 1b9fc70 into tikv:master Dec 15, 2022
@rleungx rleungx deleted the fix-version branch December 15, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version is none
5 participants