resource_manager: basic implement about manage resource group #5785
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
nolouch
force-pushed
the
resource-manager/server_part2
branch
from
0a3f5a7
to
822a745
Compare
Codecov ReportBase: 75.54% // Head: 75.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5785 +/- ##
==========================================
+ Coverage 75.54% 75.58% +0.03%
==========================================
Files 330 337 +7
Lines 32996 33278 +282
==========================================
+ Hits 24927 25153 +226
- Misses 5911 5957 +46
- Partials 2158 2168 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nolouch
force-pushed
the
resource-manager/server_part2
branch
2 times, most recently
from
01383fa
to
d0c8b1d
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
force-pushed
the
resource-manager/server_part2
branch
from
d0c8b1d
to
1b86299
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
force-pushed
the
resource-manager/server_part2
branch
from
e959b99
to
400f1ef
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
|
ptal again, thanks @JmPotato @CabinfeverB @BornChanger |
Signed-off-by: nolouch <nolouch@gmail.com>
|
@BornChanger: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: ead68eb
|
ti-chi-bot
added
the
status/can-merge
| @@ -12,5 +12,5 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| // Package mcs used to implement the core logic of the external services which rely on the PD banckend provider. | |||
| package mcs | |||
| // Package msc used to implement the core logic of the external services which rely on the PD banckend provider. | |||
| func (s *Service) RegisterRouter() { | ||
| configEndpoint := s.baseEndpoint.Group("/config") | ||
| configEndpoint.POST("/group", s.postResourceGroup) | ||
| configEndpoint.PUT("group", s.putResourceGroup) |
There was a problem hiding this comment.
This routing config is probably missing slash in front of group
| } | ||
|
|
||
| // NewManager returns a new Manager. | ||
| func NewManager(srv *server.Server) *Manager { |
There was a problem hiding this comment.
The abbreviation of server is svr instead of srv.
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
Issue Number: Ref #5784
What is changed and how does it work?
Check List
Tests
Release note