Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

movingaverage: reduce memory consume #5798

Merged
merged 3 commits into from Dec 23, 2022
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Dec 22, 2022

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Issue Number: Ref #5692

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

 None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 75.56% // Head: 75.61% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (148710c) compared to base (882eb1d).
Patch coverage: 94.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5798      +/-   ##
==========================================
+ Coverage   75.56%   75.61%   +0.04%     
==========================================
  Files         337      337              
  Lines       33278    33262      -16     
==========================================
+ Hits        25147    25150       +3     
+ Misses       5958     5944      -14     
+ Partials     2173     2168       -5     
Flag Coverage Δ
unittests 75.61% <94.44%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/statistics/hot_cache.go 85.18% <ø> (-1.18%) ⬇️
pkg/movingaverage/avg_over_time.go 96.07% <66.66%> (-1.84%) ⬇️
pkg/mock/mockcluster/mockcluster.go 93.94% <100.00%> (ø)
pkg/movingaverage/median_filter.go 100.00% <100.00%> (ø)
pkg/movingaverage/time_median.go 100.00% <100.00%> (ø)
pkg/utils/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
pkg/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
pkg/member/member.go 64.21% <0.00%> (-1.58%) ⬇️
server/schedulers/hot_region_v2.go 88.30% <0.00%> (-1.17%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2022
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any benchmark? is only one field removed?

@lhy1024
Copy link
Contributor Author

lhy1024 commented Dec 23, 2022

Any benchmark? is only one field removed?

Reduce 4.47%

Before 2584.45MB
Image
After 2468.85MB
Image

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2022
@nolouch
Copy link
Contributor

nolouch commented Dec 23, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7a7f744

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 23, 2022
@ti-chi-bot
Copy link
Member

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7c43985 into tikv:master Dec 23, 2022
@lhy1024 lhy1024 deleted the refactor-hot branch December 23, 2022 06:02
ti-chi-bot added a commit that referenced this pull request Mar 3, 2023
ref #5798, close #6069

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Mar 3, 2023
ref tikv#5798, close tikv#6069

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot added a commit that referenced this pull request Mar 3, 2023
ref #5798, close #6069, ref #6080

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants