New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: reduce log zap cpu time #5859
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 75.42% // Head: 75.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5859 +/- ##
==========================================
+ Coverage 75.42% 75.46% +0.04%
==========================================
Files 337 337
Lines 34123 34129 +6
==========================================
+ Hits 25736 25757 +21
+ Misses 6163 6151 -12
+ Partials 2224 2221 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
how about move it to the github.com/pingcap/log repo? |
Please add a benchmark for it, not only the profile. |
good idea |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ab9b940
|
@lhy1024: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f6a15ca
|
Signed-off-by: lhy1024 admin@liudos.us
What problem does this PR solve?
This pr avoid zap before passing the reference but we need a better way to reduce zap cpu time
Issue Number: Ref #5692
What is changed and how does it work?
Check List
Tests
Release note