Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: remove maxRequestTokens in limiter #5880

Merged
merged 2 commits into from Jan 29, 2023

Conversation

CabinfeverB
Copy link
Member

Signed-off-by: Cabinfever_B cabinfeveroier@gmail.com

What problem does this PR solve?

Issue Number: ref #5851

What is changed and how does it work?

Take the facts, we don't have to check too big request.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2023
Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Base: 75.76% // Head: 75.70% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (d7a62ad) compared to base (5c518d0).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5880      +/-   ##
==========================================
- Coverage   75.76%   75.70%   -0.06%     
==========================================
  Files         342      342              
  Lines       34834    34828       -6     
==========================================
- Hits        26391    26367      -24     
- Misses       6205     6217      +12     
- Partials     2238     2244       +6     
Flag Coverage Δ
unittests 75.70% <66.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/resource_manager/client/config.go 44.44% <ø> (-2.93%) ⬇️
pkg/mcs/resource_manager/client/client.go 68.47% <62.50%> (ø)
pkg/mcs/resource_manager/client/limiter.go 82.75% <100.00%> (+0.09%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/utils/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
server/region_syncer/client.go 81.34% <0.00%> (-5.23%) ⬇️
pkg/utils/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/tso/allocator_manager.go 63.87% <0.00%> (-2.10%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 29, 2023
@nolouch
Copy link
Contributor

nolouch commented Jan 29, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d7a62ad

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 29, 2023
@ti-chi-bot ti-chi-bot merged commit c55e632 into tikv:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants