Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_manager: move client to client mod #5914

Merged
merged 8 commits into from Feb 6, 2023

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Feb 6, 2023

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Issue Number: Fix #5913

What is changed and how does it work?

move files

Check List

Tests

  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Fix tikv#5913

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 75.63% // Head: 75.58% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (f219808) compared to base (3844971).
Patch coverage: 66.66% of modified lines in pull request are covered.

❗ Current head f219808 differs from pull request most recent head 55b8b1a. Consider uploading reports for the commit 55b8b1a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5914      +/-   ##
==========================================
- Coverage   75.63%   75.58%   -0.06%     
==========================================
  Files         344      344              
  Lines       35121    35121              
==========================================
- Hits        26564    26545      -19     
- Misses       6271     6294      +23     
+ Partials     2286     2282       -4     
Flag Coverage Δ
unittests 75.58% <66.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/resource_manager/client/client.go 63.61% <ø> (ø)
client/resource_manager/client/limiter.go 60.00% <ø> (ø)
client/resource_manager/client/config.go 44.44% <50.00%> (ø)
client/resource_manager/client/model.go 79.54% <100.00%> (ø)
pkg/utils/etcdutil/etcdutil.go 84.88% <0.00%> (-3.49%) ⬇️
pkg/id/id.go 86.44% <0.00%> (-3.39%) ⬇️
server/schedulers/random_merge.go 62.50% <0.00%> (-3.13%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2023
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 6, 2023
@disksing
Copy link
Contributor Author

disksing commented Feb 6, 2023

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 55b8b1a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 6, 2023
@ti-chi-bot ti-chi-bot merged commit 393b287 into tikv:master Feb 6, 2023
@disksing disksing deleted the move-resource-controller branch February 6, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move resource controller to client mod
4 participants