New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton to initialize tso microservice #5917
Add skeleton to initialize tso microservice #5917
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @binshi-bing. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportBase: 75.35% // Head: 75.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5917 +/- ##
==========================================
+ Coverage 75.35% 75.43% +0.07%
==========================================
Files 347 348 +1
Lines 35482 35486 +4
==========================================
+ Hits 26739 26769 +30
+ Misses 6406 6394 -12
+ Partials 2337 2323 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
0a22f7e
to
03081c6
Compare
This PR is closed by accident. I did the following thing:
Questions:
|
OK, I can reopen it when I updated the previous comment. I'm still wondering what's the recommend way at step 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
68f317a
to
fb09b95
Compare
fb09b95
to
240a2a7
Compare
240a2a7
to
6f5f084
Compare
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6f5f084
|
/ok-to-test |
/test build |
/rebuild |
/retest |
@binshi-bing: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Issue Number: ref #5836
Signed-off-by: Bin Shi binshi.bing@gmail.com
What problem does this PR solve?
Issue Number: Ref #5836
What is changed and how does it work?
Check List
Tests
I did some compatibility test manually by verifying that the all-in-one pd-server can start normally w/o and w/ parameter.
Code changes
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note