Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix the package name #5919

Merged
merged 2 commits into from Feb 7, 2023
Merged

*: fix the package name #5919

merged 2 commits into from Feb 7, 2023

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 7, 2023

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Ref #4820.

What is changed and how does it work?

Check List

Tests

  • No code

Release note

None

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 7, 2023
@rleungx rleungx requested review from CabinfeverB and removed request for nolouch and disksing February 7, 2023 04:03
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2023
@rleungx
Copy link
Member Author

rleungx commented Feb 7, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 75572f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 75.51% // Head: 75.50% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (39f1d25) compared to base (8bfb86d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5919      +/-   ##
==========================================
- Coverage   75.51%   75.50%   -0.02%     
==========================================
  Files         345      345              
  Lines       35126    35126              
==========================================
- Hits        26526    26522       -4     
- Misses       6310     6313       +3     
- Partials     2290     2291       +1     
Flag Coverage Δ
unittests 75.50% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/util.go 56.60% <ø> (ø)
pkg/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
pkg/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
server/storage/storage.go 67.30% <0.00%> (-3.85%) ⬇️
pkg/tso/tso.go 67.97% <0.00%> (-2.81%) ⬇️
server/schedule/labeler/labeler.go 76.77% <0.00%> (-2.59%) ⬇️
pkg/storage/endpoint/meta.go 61.36% <0.00%> (-2.28%) ⬇️
pkg/election/leadership.go 75.25% <0.00%> (-2.07%) ⬇️
server/schedule/hbstream/heartbeat_streams.go 78.78% <0.00%> (-2.03%) ⬇️
pkg/member/member.go 64.21% <0.00%> (-1.58%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot merged commit 77d7be0 into tikv:master Feb 7, 2023
@rleungx rleungx deleted the typo1 branch February 7, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants