New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump alpine image to 3.17 #5969
Conversation
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @AmoebaProtozoa. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 267e145
|
plz set issue level |
I don't think I have the privilege to do that, can you add it? |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-all-tests |
/run-check-issue-triage-complete |
/run-all-tests |
Codecov ReportBase: 75.22% // Head: 75.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5969 +/- ##
==========================================
- Coverage 75.22% 75.12% -0.11%
==========================================
Files 362 362
Lines 36232 36304 +72
==========================================
+ Hits 27255 27272 +17
- Misses 6601 6654 +53
- Partials 2376 2378 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@AmoebaProtozoa: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
I think it needs a |
/ok-to-test |
Signed-off-by: David 8039876+AmoebaProtozoa@users.noreply.github.com
What problem does this PR solve?
Issue Number: Close #5968
What is changed and how does it work?
current runner image from docker file is based on alpine 3.5, which reached end of life more than 4 years ago (2018-11-01) and does not support arm build. This PR bumps it to a more recent 3.17, same as golang:1.19-alpine used in builder.
further more,
binutils-gold
is added to avoid errors likefatal error: cannot find 'ld'
, similar issues can be seen here: golang/go#52399Check List
Tests
make docker-image
now finished successfully on m1 mac.Release note