Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump alpine image to 3.17 #5969

Merged
merged 8 commits into from Feb 13, 2023
Merged

Conversation

AmoebaProtozoa
Copy link
Contributor

@AmoebaProtozoa AmoebaProtozoa commented Feb 12, 2023

Signed-off-by: David 8039876+AmoebaProtozoa@users.noreply.github.com

What problem does this PR solve?

Issue Number: Close #5968

What is changed and how does it work?

current runner image from docker file is based on alpine 3.5, which reached end of life more than 4 years ago (2018-11-01) and does not support arm build. This PR bumps it to a more recent 3.17, same as golang:1.19-alpine used in builder.

further more, binutils-gold is added to avoid errors like fatal error: cannot find 'ld', similar issues can be seen here: golang/go#52399
image

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    make docker-image now finished successfully on m1 mac.
    image

Release note

None

Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 12, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Hi @AmoebaProtozoa. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2023
@nolouch
Copy link
Contributor

nolouch commented Feb 13, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 267e145

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Feb 13, 2023

plz set issue level

@AmoebaProtozoa
Copy link
Contributor Author

AmoebaProtozoa commented Feb 13, 2023

plz set issue level

I don't think I have the privilege to do that, can you add it?

@lhy1024
Copy link
Contributor

lhy1024 commented Feb 13, 2023

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor

lhy1024 commented Feb 13, 2023

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Feb 13, 2023

/run-check-issue-triage-complete

@lhy1024
Copy link
Contributor

lhy1024 commented Feb 13, 2023

/run-all-tests

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 75.22% // Head: 75.12% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (302aefb) compared to base (5a8f93d).
Patch coverage: 57.14% of modified lines in pull request are covered.

❗ Current head 302aefb differs from pull request most recent head 6e751ce. Consider uploading reports for the commit 6e751ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5969      +/-   ##
==========================================
- Coverage   75.22%   75.12%   -0.11%     
==========================================
  Files         362      362              
  Lines       36232    36304      +72     
==========================================
+ Hits        27255    27272      +17     
- Misses       6601     6654      +53     
- Partials     2376     2378       +2     
Flag Coverage Δ
unittests 75.12% <57.14%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/resource_manager/client/client.go 61.09% <39.53%> (-1.78%) ⬇️
client/resource_manager/client/model.go 63.49% <44.00%> (-16.06%) ⬇️
pkg/mcs/resource_manager/server/token_bukets.go 90.00% <63.63%> (-3.55%) ⬇️
client/resource_manager/client/limiter.go 63.75% <84.61%> (+6.99%) ⬆️
pkg/utils/etcdutil/etcdutil.go 83.49% <88.23%> (-1.39%) ⬇️
server/apiv2/handlers/keyspace.go 64.81% <100.00%> (ø)
server/server.go 73.97% <100.00%> (-0.91%) ⬇️
pkg/dashboard/keyvisual/input/core.go 0.00% <0.00%> (-33.34%) ⬇️
pkg/tso/local_allocator.go 71.62% <0.00%> (-4.06%) ⬇️
pkg/tso/allocator_manager.go 62.25% <0.00%> (-3.71%) ⬇️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot
Copy link
Member

@AmoebaProtozoa: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AmoebaProtozoa
Copy link
Contributor Author

I think it needs a /test build or a ok-to-test label for ci to start running
@lhy1024

@lhy1024
Copy link
Contributor

lhy1024 commented Feb 13, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot merged commit 31355ad into tikv:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make docker-image failed on m1 mac
4 participants