New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor some common utilities which will be used by the upcoming TSO microservice change #5985
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @binshi-bing. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cb90c16
to
75032dd
Compare
Codecov ReportBase: 75.13% // Head: 75.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5985 +/- ##
==========================================
- Coverage 75.13% 75.11% -0.03%
==========================================
Files 362 362
Lines 36282 36280 -2
==========================================
- Hits 27262 27250 -12
- Misses 6645 6651 +6
- Partials 2375 2379 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
75032dd
to
d05b67a
Compare
d05b67a
to
ee78f47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM.
ee78f47
to
0851a19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve for moving these two functions
/ok-to-test |
0851a19
to
6944aa6
Compare
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6944aa6
|
This change is split from "basic implement tso gPRC service #5949"
Signed-off-by: Bin Shi binshi.bing@gmail.com
What problem does this PR solve?
Issue Number: Ref #5836
What is changed and how does it work?
This change is split from basic implement tso gPRC service #5949
Check List
Tests
Code changes
Side effects
None
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note