Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some common utilities which will be used by the upcoming TSO microservice change #5985

Merged
merged 1 commit into from Feb 14, 2023

Conversation

binshi-bing
Copy link
Contributor

@binshi-bing binshi-bing commented Feb 13, 2023

This change is split from "basic implement tso gPRC service #5949"

Signed-off-by: Bin Shi binshi.bing@gmail.com

What problem does this PR solve?

Issue Number: Ref #5836

What is changed and how does it work?

This change is split from basic implement tso gPRC service #5949

    Refactor some common utilities which will be used by tso mcs

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

None

Related changes

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Hi @binshi-bing. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 75.13% // Head: 75.11% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (6944aa6) compared to base (e6086c4).
Patch coverage: 77.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5985      +/-   ##
==========================================
- Coverage   75.13%   75.11%   -0.03%     
==========================================
  Files         362      362              
  Lines       36282    36280       -2     
==========================================
- Hits        27262    27250      -12     
- Misses       6645     6651       +6     
- Partials     2375     2379       +4     
Flag Coverage Δ
unittests 75.11% <77.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/server.go 74.87% <0.00%> (-0.90%) ⬇️
server/util.go 46.37% <ø> (-5.31%) ⬇️
pkg/utils/etcdutil/etcdutil.go 84.49% <69.23%> (-0.95%) ⬇️
pkg/utils/grpcutil/grpcutil.go 70.68% <100.00%> (+3.38%) ⬆️
server/grpc_service.go 49.07% <100.00%> (-0.09%) ⬇️
pkg/utils/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
client/resource_group/controller/limiter.go 61.25% <0.00%> (-6.25%) ⬇️
pkg/member/member.go 60.00% <0.00%> (-4.22%) ⬇️
server/schedulers/random_merge.go 62.50% <0.00%> (-4.17%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

pkg/mcs/tso/server/server.go Outdated Show resolved Hide resolved
pkg/mcs/tso/server/server.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve for moving these two functions

@lhy1024
Copy link
Contributor

lhy1024 commented Feb 14, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6944aa6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit 5e07877 into tikv:master Feb 14, 2023
@binshi-bing binshi-bing deleted the refactor-some-common-util branch February 14, 2023 17:11
nolouch pushed a commit to nolouch/pd that referenced this pull request Feb 24, 2023
… microservice change (tikv#5985)

ref tikv#5836, ref tikv#5949

Refactor some common utilities which will be used by tso mcs

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants