New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix the default value of peer-urls #5996
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@glorv PTAL |
Codecov ReportBase: 75.06% // Head: 75.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5996 +/- ##
==========================================
+ Coverage 75.06% 75.11% +0.05%
==========================================
Files 362 362
Lines 36316 36316
==========================================
+ Hits 27260 27280 +20
+ Misses 6677 6663 -14
+ Partials 2379 2373 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d729d93
|
What problem does this PR solve?
Issue Number: Ref #5836.
What is changed and how does it work?
Previously, #5971 change the default value of
peer-urls
by accident. This PR fixes it.Check List
Tests
Release note