Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup: refine the handling of error 'no cpu controller detected' #5999

Merged
merged 10 commits into from
Feb 16, 2023

Conversation

hnes
Copy link
Contributor

@hnes hnes commented Feb 16, 2023

What problem does this PR solve?

Issue Number: Ref #5953

What is changed and how does it work?

Ignore error 'no cpu controller detected' on old kernel but still panic on new kernel. (Thanks a lot for the advice from @nolouch)
Remove TestGetCgroupCPU from the flaky test list.

Reference:
pingcap/tidb#41347
pingcap/tidb#41475

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 16, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Hi @hnes. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hnes
Copy link
Contributor Author

hnes commented Feb 16, 2023

/cc @nolouch

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 75.09% // Head: 75.32% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (4cf1374) compared to base (c499e01).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4cf1374 differs from pull request most recent head 00b04b8. Consider uploading reports for the commit 00b04b8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5999      +/-   ##
==========================================
+ Coverage   75.09%   75.32%   +0.23%     
==========================================
  Files         362      362              
  Lines       36316    36316              
==========================================
+ Hits        27270    27356      +86     
+ Misses       6668     6612      -56     
+ Partials     2378     2348      -30     
Flag Coverage Δ
unittests 75.32% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cgroup/cgroup_cpu.go 78.12% <100.00%> (ø)
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
pkg/storage/endpoint/meta.go 63.63% <0.00%> (-2.28%) ⬇️
server/config/persist_options.go 91.98% <0.00%> (-0.65%) ⬇️
client/base_client.go 83.17% <0.00%> (-0.47%) ⬇️
client/client.go 70.75% <0.00%> (-0.11%) ⬇️
server/cluster/cluster.go 81.63% <0.00%> (ø)
server/server.go 75.51% <0.00%> (+0.51%) ⬆️
server/statistics/store_collection.go 91.56% <0.00%> (+0.60%) ⬆️
server/schedule/operator/step.go 77.30% <0.00%> (+0.67%) ⬆️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Sen Han <00hnes@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Feb 16, 2023

/ok-to-test

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 16, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 16, 2023
@lhy1024
Copy link
Contributor

lhy1024 commented Feb 16, 2023

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 00b04b8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@ti-chi-bot ti-chi-bot merged commit f99da66 into tikv:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants