Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdutil: support multi backends client #6046

Merged
merged 4 commits into from Feb 24, 2023
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Feb 24, 2023

What problem does this PR solve?

Issue Number: Close #6042

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 24, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 24, 2023

cc @binshi-bing @rleungx

Signed-off-by: lhy1024 <admin@liudos.us>
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 74.90% // Head: 74.90% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d8741ad) compared to base (94d05f0).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6046   +/-   ##
=======================================
  Coverage   74.90%   74.90%           
=======================================
  Files         365      366    +1     
  Lines       36552    36562   +10     
=======================================
+ Hits        27378    27388   +10     
+ Misses       6786     6783    -3     
- Partials     2388     2391    +3     
Flag Coverage Δ
unittests 74.90% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/resource_manager/server/server.go 48.05% <ø> (ø)
pkg/utils/etcdutil/etcdutil.go 80.48% <78.94%> (-0.14%) ⬇️
client/base_client.go 83.17% <100.00%> (ø)
pkg/core/region_tree.go 95.56% <100.00%> (ø)
pkg/utils/etcdutil/testutil.go 100.00% <100.00%> (ø)
server/schedule/waiting_operator.go 97.36% <100.00%> (ø)
server/server.go 74.38% <100.00%> (-0.26%) ⬇️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
pkg/storage/endpoint/rule.go 83.33% <0.00%> (-11.12%) ⬇️
pkg/utils/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: lhy1024 <admin@liudos.us>
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the unresolved comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2023
Signed-off-by: lhy1024 <admin@liudos.us>
@@ -41,6 +38,9 @@ const (
// defaultEtcdClientTimeout is the default timeout for etcd client.
defaultEtcdClientTimeout = 3 * time.Second

// defaultAutoSyncInterval is the interval to sync etcd cluster.
defaultAutoSyncInterval = 60 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Is there some releationship between the timeouts, like defaultEtcdClientTimeout ,DefaultDialTimeout,DefaultRequestTimeout?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 24, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 24, 2023

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d8741ad

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2023
@ti-chi-bot ti-chi-bot merged commit 833e5fc into tikv:master Feb 24, 2023
@lhy1024 lhy1024 deleted the client2 branch March 2, 2023 03:25
ti-chi-bot added a commit that referenced this pull request Mar 7, 2023
…sible (#6059)

ref #6046, close #6053, ref #6059

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@rleungx rleungx mentioned this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mcs: support multi backends client
4 participants