Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: return the consumption info on RU request/response #6125

Merged
merged 4 commits into from Mar 13, 2023
Merged

controller: return the consumption info on RU request/response #6125

merged 4 commits into from Mar 13, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Mar 9, 2023 •
edited

What problem does this PR solve?

Issue Number: ref #5851. Part of pingcap/tidb#41972.

What is changed and how does it work?

- Return the consumption info on RU request/response.
- Remove some unnecessary `goto`s.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2023 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@JmPotato JmPotato requested review from CabinfeverB and removed request for disksing March 9, 2023 08:47
@codecov
Copy link

codecov bot commented Mar 9, 2023 •
edited

Codecov Report

Patch coverage: 68.51% and project coverage change: -0.01 ⚠️

Comparison is base (5bdfa71) 74.45% compared to head (26cb5ce) 74.44%.

❗ Current head 26cb5ce differs from pull request most recent head 03b748e. Consider uploading reports for the commit 03b748e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6125      +/-   ##
==========================================
- Coverage   74.45%   74.44%   -0.01%     
==========================================
  Files         389      390       +1     
  Lines       38152    38144       -8     
==========================================
- Hits        28405    28398       -7     
- Misses       7225     7227       +2     
+ Partials     2522     2519       -3
Flag Coverage Δ
unittests 74.44% <68.51%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/resource_group/controller/controller.go 64.84% <59.52%> (+0.30%) ⬆️
client/resource_group/controller/testutil.go 100.00% <100.00%> (ø)

... and 32 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JmPotato JmPotato mentioned this pull request Mar 10, 2023
Merged
@JmPotato JmPotato force-pushed the ru_runtime_stats branch 2 times, most recently from c0635f6 to 8fa8ca3 Compare March 13, 2023 03:22
@JmPotato
Return the consumption info on RU request/response
ff9b83a 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Refine onRequestWait
8851587 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

@nolouch @CabinfeverB @HuSharp PTAL, thx.

@JmPotato
Add some test cases
26cb5ce 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
nolouch
nolouch approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 13, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 26cb5ce

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2023
@JmPotato
Copy link
Member Author

/ok-to-test

@JmPotato
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 3e3ae55 into tikv:master Mar 13, 2023
16 checks passed
@JmPotato JmPotato deleted the ru_runtime_stats branch March 13, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

Assignees
No one assigned
Labels
component/resource-control ok-to-test release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JmPotato @ti-chi-bot @nolouch @CabinfeverB