Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect /admin/reset-ts to tso under microservice mode #6132

Merged
merged 5 commits into from Mar 15, 2023

Conversation

hnes
Copy link
Contributor

@hnes hnes commented Mar 9, 2023

What problem does this PR solve?

Issue Number: ref #5836

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

Signed-off-by: Sen Han <00hnes@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none needs-ok-to-test labels Mar 9, 2023
@ti-chi-bot
Copy link
Member

Hi @hnes. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 57.89% and project coverage change: +0.14 🎉

Comparison is base (c7227ff) 74.32% compared to head (2b49db7) 74.47%.

❗ Current head 2b49db7 differs from pull request most recent head 764b6e5. Consider uploading reports for the commit 764b6e5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6132      +/-   ##
==========================================
+ Coverage   74.32%   74.47%   +0.14%     
==========================================
  Files         392      391       -1     
  Lines       38172    38205      +33     
==========================================
+ Hits        28373    28453      +80     
+ Misses       7293     7234      -59     
- Partials     2506     2518      +12     
Flag Coverage Δ
unittests 74.47% <57.89%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/server.go 74.93% <ø> (-0.38%) ⬇️
pkg/utils/apiutil/serverapi/middleware.go 60.60% <55.55%> (-12.37%) ⬇️
server/api/server.go 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lhy1024
Copy link
Contributor

lhy1024 commented Mar 9, 2023

/ok-to-test

Signed-off-by: Sen Han <00hnes@gmail.com>
Signed-off-by: Sen Han <00hnes@gmail.com>
@hnes hnes marked this pull request as ready for review March 10, 2023 11:56
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023
@hnes
Copy link
Contributor Author

hnes commented Mar 10, 2023

/cc @rleungx

@ti-chi-bot ti-chi-bot requested a review from rleungx March 10, 2023 11:57
@hnes
Copy link
Contributor Author

hnes commented Mar 10, 2023

/cc @binshi-bing

@ti-chi-bot
Copy link
Member

@hnes: GitHub didn't allow me to request PR reviews from the following users: binshi-bing.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @binshi-bing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@binshi-bing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rleungx
Copy link
Member

rleungx commented Mar 14, 2023

Have you tested it?

@hnes
Copy link
Contributor Author

hnes commented Mar 14, 2023

Yes, I tested it before the commit of "Merge branch 'master' into proxy-admin-reset-ts".

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2023
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2023
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 15, 2023
@nolouch
Copy link
Contributor

nolouch commented Mar 15, 2023

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b49db7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2023
@ti-chi-bot
Copy link
Member

@hnes: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b31b746 into tikv:master Mar 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants