New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcs: unify confusing etcd key #6158
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6158 +/- ##
==========================================
- Coverage 74.49% 74.36% -0.14%
==========================================
Files 392 392
Lines 38172 38172
==========================================
- Hits 28437 28387 -50
- Misses 7232 7271 +39
- Partials 2503 2514 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -405,7 +405,7 @@ func (s *Server) startServer() (err error) { | |||
|
|||
// Server has started. | |||
atomic.StoreInt64(&s.isServing, 1) | |||
s.serviceRegister = discovery.NewServiceRegister(s.ctx, s.etcdClient, "resource_manager", s.cfg.ListenAddr, s.cfg.ListenAddr, discovery.DefaultLeaseInSeconds) | |||
s.serviceRegister = discovery.NewServiceRegister(s.ctx, s.etcdClient, "resource-manager", s.cfg.ListenAddr, s.cfg.ListenAddr, discovery.DefaultLeaseInSeconds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use _
.
Signed-off-by: lhy1024 <admin@liudos.us>
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 52a61df
|
What problem does this PR solve?
Issue Number: Close #6157
What is changed and how does it work?
Check List
Tests
Release note