scheduler: bugfix for slow-trend-scheduler when timestamp of heartbeats are equal #6273

LykxSassinator · 2023-04-06T03:50:27Z

What problem does this PR solve?

Issue Number: Close #6307

What is changed and how does it work?

Update the strategy on the judgement whether all timestamps have been updated or not when detecting slow stores.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has the configuration change
Has HTTP API interfaces changed (Don't forget to add the declarative for the new API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

ti-chi-bot · 2023-04-06T03:50:28Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
bufferflies

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-04-06T03:50:36Z

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

codecov · 2023-04-11T12:33:32Z

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (cb3bd5f) 75.11% compared to head (b2b6337) 75.08%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6273      +/-   ##
==========================================
- Coverage   75.11%   75.08%   -0.04%     
==========================================
  Files         404      404              
  Lines       39780    39781       +1     
==========================================
- Hits        29881    29868      -13     
- Misses       7277     7291      +14     
  Partials     2622     2622

Flag	Coverage Δ
unittests	`75.08% <100.00%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/schedule/schedulers/evict_slow_trend.go	`64.86% <100.00%> (+0.15%)`	⬆️

... and 34 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

LykxSassinator · 2023-04-12T03:43:43Z

@innerr PTAL, thx

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

innerr

LGTM

ti-chi-bot · 2023-04-12T03:58:06Z

@innerr: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

LykxSassinator · 2023-04-13T02:16:41Z

@bufferflies PTAL,thx

pkg/schedule/schedulers/evict_slow_trend.go

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

JmPotato · 2023-04-13T05:57:28Z

/merge

ti-chi-bot · 2023-04-13T05:57:29Z

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-04-13T05:57:31Z

This pull request has been accepted and is ready to merge.

Commit hash: 260a805

LykxSassinator · 2023-04-13T07:05:20Z

/check-issue-triage-complete

ti-chi-bot · 2023-04-13T10:49:14Z

@LykxSassinator: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

LykxSassinator · 2023-04-13T13:12:11Z

/run-build

LykxSassinator · 2023-04-13T13:12:41Z

/build

wuhuizuo · 2023-04-13T13:16:44Z

/test build

ti-chi-bot · 2023-04-13T13:16:58Z

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bufferflies · 2023-04-13T13:24:29Z

/ok-to-test

Add annoatations for bugfix waited to be done in next works.

ee689ee

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

ti-chi-bot added do-not-merge/needs-linked-issue release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 6, 2023

ti-chi-bot requested review from JmPotato and nolouch April 6, 2023 03:50

ti-chi-bot added the needs-ok-to-test label Apr 6, 2023

Bugfix for checking the update of stores.

3c1718a

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

LykxSassinator added 2 commits April 12, 2023 10:58

Revoke unnecessary annotations.

cd879f9

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

Merge branch 'master' into bugfix_detect_slowness

7c0fa6c

ti-chi-bot added do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Apr 12, 2023

LykxSassinator marked this pull request as ready for review April 12, 2023 03:43

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2023

Polish logs.

227e7fb

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

innerr approved these changes Apr 12, 2023

View reviewed changes

Merge branch 'master' into bugfix_detect_slowness

9844063

bufferflies reviewed Apr 13, 2023

View reviewed changes

pkg/schedule/schedulers/evict_slow_trend.go Outdated Show resolved Hide resolved

Polish codes.

260a805

Signed-off-by: Lucasliang <nkcs_lykx@hotmail.com>

bufferflies approved these changes Apr 13, 2023

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2023

JmPotato approved these changes Apr 13, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2023

Merge branch 'master' into bugfix_detect_slowness

f6a4a3c

ti-chi-bot removed the do-not-merge/needs-triage-completed label Apr 13, 2023

ti-chi-bot added 4 commits April 13, 2023 15:07

Merge branch 'master' into bugfix_detect_slowness

ad1a69d

Merge branch 'master' into bugfix_detect_slowness

fb1b064

Merge branch 'master' into bugfix_detect_slowness

aa9133c

Merge branch 'master' into bugfix_detect_slowness

b2b6337

ti-chi-bot added ok-to-test and removed needs-ok-to-test labels Apr 13, 2023

ti-chi-bot merged commit 4201238 into tikv:master Apr 13, 2023
21 checks passed

LykxSassinator deleted the bugfix_detect_slowness branch April 13, 2023 13:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scheduler: bugfix for slow-trend-scheduler when timestamp of heartbeats are equal #6273

scheduler: bugfix for slow-trend-scheduler when timestamp of heartbeats are equal #6273

LykxSassinator commented Apr 6, 2023 •

edited

ti-chi-bot commented Apr 6, 2023 •

edited

ti-chi-bot commented Apr 6, 2023

codecov bot commented Apr 11, 2023 •

edited

LykxSassinator commented Apr 12, 2023

innerr left a comment

ti-chi-bot commented Apr 12, 2023

LykxSassinator commented Apr 13, 2023

JmPotato commented Apr 13, 2023

ti-chi-bot commented Apr 13, 2023

ti-chi-bot commented Apr 13, 2023

LykxSassinator commented Apr 13, 2023

ti-chi-bot commented Apr 13, 2023

LykxSassinator commented Apr 13, 2023

LykxSassinator commented Apr 13, 2023

wuhuizuo commented Apr 13, 2023

ti-chi-bot commented Apr 13, 2023

bufferflies commented Apr 13, 2023

scheduler: bugfix for slow-trend-scheduler when timestamp of heartbeats are equal #6273

scheduler: bugfix for slow-trend-scheduler when timestamp of heartbeats are equal #6273

Conversation

LykxSassinator commented Apr 6, 2023 • edited

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Apr 6, 2023 • edited

ti-chi-bot commented Apr 6, 2023

codecov bot commented Apr 11, 2023 • edited

Codecov Report

LykxSassinator commented Apr 12, 2023

innerr left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Apr 12, 2023

LykxSassinator commented Apr 13, 2023

JmPotato commented Apr 13, 2023

ti-chi-bot commented Apr 13, 2023

ti-chi-bot commented Apr 13, 2023

LykxSassinator commented Apr 13, 2023

ti-chi-bot commented Apr 13, 2023

LykxSassinator commented Apr 13, 2023

LykxSassinator commented Apr 13, 2023

wuhuizuo commented Apr 13, 2023

ti-chi-bot commented Apr 13, 2023

bufferflies commented Apr 13, 2023

LykxSassinator commented Apr 6, 2023 •

edited

ti-chi-bot commented Apr 6, 2023 •

edited

codecov bot commented Apr 11, 2023 •

edited