Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: hot-region-scheduler store pick consider the history loads to decrease incorrect operator #6276

Closed
wants to merge 17 commits into from

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Apr 6, 2023

What problem does this PR solve?

Issue Number: Close #6297

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note

None.

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Apr 6, 2023
Signed-off-by: bufferflies <1045931706@qq.com>
@bufferflies bufferflies changed the title scheduler: hot-region-scheduler store pick consider the history loads to decrease incorrent operator scheduler: hot-region-scheduler store pick consider the history loads to decrease incorrect operator Apr 7, 2023
Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 82.22% and project coverage change: +0.13 🎉

Comparison is base (bfdc7ec) 75.09% compared to head (08aa49a) 75.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6276      +/-   ##
==========================================
+ Coverage   75.09%   75.22%   +0.13%     
==========================================
  Files         404      404              
  Lines       39350    39538     +188     
==========================================
+ Hits        29549    29742     +193     
- Misses       7228     7229       +1     
+ Partials     2573     2567       -6     
Flag Coverage Δ
unittests 75.22% <82.22%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/movingaverage/exponential_moving_average.go 96.42% <0.00%> (-3.58%) ⬇️
pkg/movingaverage/hull_moving_average.go 95.23% <0.00%> (-4.77%) ⬇️
pkg/movingaverage/weight_moving_average.go 82.75% <0.00%> (-9.55%) ⬇️
pkg/statistics/store_load.go 97.97% <ø> (ø)
server/handler.go 52.38% <0.00%> (-0.41%) ⬇️
pkg/movingaverage/max_filter.go 85.00% <66.66%> (-3.24%) ⬇️
pkg/movingaverage/median_filter.go 96.29% <66.66%> (-3.71%) ⬇️
pkg/schedule/schedulers/hot_region.go 84.08% <80.39%> (-0.42%) ⬇️
pkg/statistics/store.go 90.76% <92.30%> (+0.17%) ⬆️
pkg/statistics/collector.go 93.58% <93.33%> (-0.17%) ⬇️
... and 5 more

... and 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bufferflies bufferflies marked this pull request as ready for review April 10, 2023 07:06
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2023
@bufferflies
Copy link
Contributor Author

/closed by #6314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot-region-scheduler should be more stable if the loads are not stable
2 participants