Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "non-default keyspace groups use the same timestamp path by mistake" #6457

Merged
merged 9 commits into from
May 16, 2023
Merged

Fix "non-default keyspace groups use the same timestamp path by mistake" #6457

merged 9 commits into from
May 16, 2023

Commits on May 15, 2023

  1. Fix flaky TestGetMinTS. 

    The tso servers are loading keyspace groups asynchronously. Make sure all keyspace groups
are available for serving tso requests from corresponding keyspaces by querying
IsKeyspaceServing(keyspaceID, the Desired KeyspaceGroupID). if use default keyspace group id
in the query, it will always return true as the keyspace will be served by default keyspace
group before the keyspace groups are loaded.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 15, 2023
    Configuration menu
    Copy the full SHA
    bab5b56 View commit details
    Browse the repository at this point in the history

  2. Enable -v in go test for debugging 

    Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4c219c3 View commit details
    Browse the repository at this point in the history

  3. Add more debugging info 

    Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 15, 2023
    Configuration menu
    Copy the full SHA
    6450fd2 View commit details
    Browse the repository at this point in the history

  4. Fix the issue "non-default keyspace groups use the same timestamp pat… 

    …h by mistake" which actually caused this random test failure.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 15, 2023
    Configuration menu
    Copy the full SHA
    b07d8b1 View commit details
    Browse the repository at this point in the history

  5. Fix fmt error 

    Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 15, 2023
    Configuration menu
    Copy the full SHA
    cc10dde View commit details
    Browse the repository at this point in the history

  6. Fix test failures in TestTSOKeyspaceGroupSplit 

    Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 15, 2023
    Configuration menu
    Copy the full SHA
    34705ec View commit details
    Browse the repository at this point in the history

  7. remove -v from ci-test-job in Makefile 

    Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 15, 2023
    Configuration menu
    Copy the full SHA
    68b1950 View commit details
    Browse the repository at this point in the history

  8. Handle feedback 

    Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 15, 2023
    Configuration menu
    Copy the full SHA
    2a4102a View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Handle more feedback 

    Signed-off-by: Bin Shi <binshi.bing@gmail.com>
    @binshi-bing
    binshi-bing committed May 16, 2023
    Configuration menu
    Copy the full SHA
    52d3f88 View commit details
    Browse the repository at this point in the history