Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: decouple coordinator with server #6503

Merged
merged 4 commits into from May 25, 2023
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented May 23, 2023

What problem does this PR solve?

Issue Number: Ref #5839.

What is changed and how does it work?

Part of #6418.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • binshi-bing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 May 23, 2023 08:18
@rleungx rleungx requested review from JmPotato and nolouch and removed request for disksing May 23, 2023 08:21
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 84.03% and project coverage change: +0.04 🎉

Comparison is base (bf7edf5) 74.97% compared to head (cca1adc) 75.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6503      +/-   ##
==========================================
+ Coverage   74.97%   75.01%   +0.04%     
==========================================
  Files         410      411       +1     
  Lines       41996    42029      +33     
==========================================
+ Hits        31487    31529      +42     
+ Misses       7753     7746       -7     
+ Partials     2756     2754       -2     
Flag Coverage Δ
unittests 75.01% <84.03%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/schedule/checker/checker_controller.go 80.00% <ø> (ø)
pkg/schedule/config/config.go 33.33% <ø> (ø)
pkg/schedule/operator/operator_controller.go 86.54% <ø> (ø)
server/api/plugin.go 8.57% <0.00%> (ø)
server/cluster/metrics.go 100.00% <ø> (ø)
server/handler.go 52.78% <0.00%> (ø)
tools/pd-ctl/pdctl/command/plugin_command.go 41.02% <0.00%> (ø)
pkg/schedule/diagnostic_manager.go 75.26% <50.00%> (ø)
pkg/mock/mockcluster/mockcluster.go 93.04% <67.85%> (-1.51%) ⬇️
pkg/schedule/coordinator.go 73.33% <86.36%> (ø)
... and 13 more

... and 36 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reset looks good to me

pkg/mock/mockcluster/mockcluster.go Outdated Show resolved Hide resolved
pkg/schedule/schedulers/range_cluster.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2023
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 24, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d7ae9d7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit f8ca1e8 into tikv:master May 25, 2023
19 checks passed
rleungx added a commit to rleungx/pd that referenced this pull request Dec 1, 2023
ref tikv#5839, ref tikv#6418

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants