Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: impl snapshot stats in simulator #6579

Merged
merged 3 commits into from Jun 21, 2023

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Jun 9, 2023

What problem does this PR solve?

Issue Number: Close #6580

What is changed and how does it work?


tiup playground v7.1.0 --host 10.200.14.54 --pd.binpath=./bin/pd-server  --kv.binpath ./bin/pd-simulator --kv=1 --db=0 --kv.config=./tikv.config

tikv.config
case-name="redundant-balance-region"
sim-tick-interval="100ms"
store-io-per-second=100

[coprocessor]
region-split-size = "10GB"
[raftstore]
capacity= "10TB"

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

None.

Signed-off-by: bufferflies <1045931706@qq.com>
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.24 🎉

Comparison is base (58d9208) 74.58% compared to head (0f48d0d) 74.83%.

❗ Current head 0f48d0d differs from pull request most recent head 095adff. Consider uploading reports for the commit 095adff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6579      +/-   ##
==========================================
+ Coverage   74.58%   74.83%   +0.24%     
==========================================
  Files         417      417              
  Lines       43068    42585     -483     
==========================================
- Hits        32124    31868     -256     
+ Misses       8090     7926     -164     
+ Partials     2854     2791      -63     
Flag Coverage Δ
unittests 74.83% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 52 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 9, 2023
@@ -43,7 +43,7 @@ import (
)

var (
pdAddr = flag.String("pd", "", "pd address")
pdAddr = flag.String("pd-endpoints", "", "pd address")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change Readme.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HuSharp
Copy link
Member

HuSharp commented Jun 12, 2023

/check-issue-triage-complete

Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2023
@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 095adff

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2023
@bufferflies
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2023

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit d9d9184 into tikv:master Jun 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simulator support the details of the snapshot report
3 participants