Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add background settings in group manager #6742

Merged
merged 3 commits into from Jul 5, 2023

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jul 3, 2023

What problem does this PR solve?

Issue Number: Close #6741

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • HuSharp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and JmPotato July 3, 2023 08:17
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2023
@nolouch nolouch requested review from HuSharp and CabinfeverB and removed request for JmPotato and HunDunDM July 3, 2023 08:17
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 3, 2023
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #6742 (0d22ad3) into master (88aec38) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 0d22ad3 differs from pull request most recent head e48b8dd. Consider uploading reports for the commit e48b8dd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6742      +/-   ##
==========================================
+ Coverage   74.25%   74.31%   +0.05%     
==========================================
  Files         411      411              
  Lines       43035    42963      -72     
==========================================
- Hits        31957    31928      -29     
+ Misses       8210     8178      -32     
+ Partials     2868     2857      -11     
Flag Coverage Δ
unittests 74.31% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 4, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 4, 2023
@@ -9,6 +9,7 @@ require (
github.com/prometheus/client_golang v1.11.1
github.com/tikv/pd/client v0.0.0-00010101000000-000000000000
go.uber.org/zap v1.24.0
google.golang.org/grpc v1.54.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, https://github.com/tikv/pd/blob/master/tools/pd-tso-bench/go.mod#L12 has been updated here, why is there no "need-rebase" label? :(

@nolouch
Copy link
Contributor Author

nolouch commented Jul 5, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0d22ad3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@nolouch: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit e9c6f33 into tikv:master Jul 5, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add background settings in group
3 participants