schedule: refactor diagnostic manager #6771
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
size/XXL
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6771 +/- ##
==========================================
- Coverage 74.20% 74.19% -0.01%
==========================================
Files 411 413 +2
Lines 43163 43172 +9
==========================================
+ Hits 32028 32031 +3
- Misses 8265 8268 +3
- Partials 2870 2873 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -0,0 +1,79 @@ | |||
| // Copyright 2022 TiKV Project Authors. | |||
There was a problem hiding this comment.
| // Copyright 2022 TiKV Project Authors. | |
| // Copyright 2023 TiKV Project Authors. |
There was a problem hiding this comment.
I think it's just a movement, maybe we don't need to change it?
| return nil, errs.ErrDiagnosticDisabled | ||
| } | ||
|
|
||
| scheduler, isSchedulerExisted := d.schedulerController[name] |
There was a problem hiding this comment.
I think there's going to be a data race. We handle schedulers in coordinator with lock, but here is no lock.
There was a problem hiding this comment.
Yes, add a lock, and I will remove it in the next PR.
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: bca5165
|
ti-chi-bot
bot
added
the
status/can-merge
|
@rleungx: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#5839 Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Ref #5839.
What is changed and how does it work?
Check List
Tests
Release note